[Feature] Tensorclass support for IQLLoss#3864
Open
aehebald wants to merge 1 commit into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3864
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 22 PendingAs of commit eefcbc8 with merge base ad8ea7f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes
IQLLoss/DiscreteIQLLossaccept tensorclass inputs, not justTensorDict.First loss converted as a template for the rest of #1062.
.get()instead oftd[key]([]is positional indexing on a tensorclass)._make_writable()inobjectives/utils.py; route network scratch selections through it(a tensorclass rejects undeclared out_keys, so convert to
TensorDict; dynamic containers pass through).test_iqlover a tensorclass input + add a tensorclass/TensorDict parity test.Motivation and Context
#1062 asks for tensorclass support across all losses. This does IQL first so the
approach can be reviewed before applying it to the rest.
Part of #1062
Types of changes
Checklist