Skip to content

Masquerade ephemeral runners as non-ephemeral ones #6545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Apr 18, 2025

This might help mitigate pytorch/pytorch#151669 until we have a proper fix. This is a silly fix.

Copy link

vercel bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2025 10:53pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2025
@huydhn huydhn changed the title Masquerade an ephemeral runner as non-ephemeral one Masquerade ephemeral runners as non-ephemeral ones Apr 18, 2025
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind this but want a second opinion from @jeanschmidt

@huydhn
Copy link
Contributor Author

huydhn commented Apr 18, 2025

@jeanschmidt If this looks ok, please feel free to merge and roll it out.

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huydhn
Copy link
Contributor Author

huydhn commented Apr 21, 2025

Chatting with @ZainRizvi , we don't need this for now as there is a way to dial down the ephemeral runner experimentation to mitigate the SEV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants