[HUD] Update some queries and regex for better viable/strict job definitions #7093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
atalman
approved these changes
Sep 4, 2025
wdvr
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to pytorch/pytorch#162100
Reason:
rocm binary builds should not be included in viable strict upgrades and metrics that look at viable strict. Also add linux-aarch64 to some since that was missing
Is this the correct way to measure trunk redness? Idk but I want it be consistent with what it says it is (considers only viable/strict blocking jobs) so we don't get confused
Some have spaces after them b/c thats the easier way to guarantee that we won't accidentally include linux-binary-manywheel-rocm when we do regex for linux-binary-manywheel, and convention states that job names that include workflow is
workflow name / job name. The places we don't need it are places that only look at workflow name and look for strict equality