Skip to content

Conversation

@huydhn huydhn requested a review from yangw-dev December 19, 2025 21:53
@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
torchci Ready Ready Preview Jan 6, 2026 2:44am

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 19, 2025
name: "PyTorch x vLLM Benchmark",
route: `/benchmark/v3/dashboard/${PYTORCH_X_VLLM_BENCHMARK_ID}`,
info: "PyTorch x vLLM nightly benchmark. Powered by [code](TODO) and [benchmark configs](https://github.com/pytorch/pytorch-integration-testing/tree/main/vllm-benchmarks/benchmarks)",
description: "Pytorch x vLLM nightly benchmark using vllm bench",
Copy link
Contributor

@yangw-dev yangw-dev Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huydhn recommend add comment that it's generated based on pinned vllm commit

Copy link
Contributor

@yangw-dev yangw-dev Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, maybe put this under vllm section: "vLLM Benchmarks ", instead of pytorch,
maybe also update the description for the vllmx pinned pytorch description, so that we can tell the difference

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it under PyTorch mainly because the users of this dashboard will be PT2 compiler looking at vllm bench from PyTorch point of view. The public vLLM v1 dashboard is a separate entity with a different group of users, maybe we would deprecate this in the future if there is no interest from vLLM maintainers in keeping it.

huydhn added 2 commits January 5, 2026 18:41
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
@huydhn huydhn merged commit 8a367f5 into main Jan 6, 2026
5 checks passed
@huydhn huydhn deleted the pytorch-x-vllm-dashboard branch January 6, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants