Allow undefined libraries to fix CMake errors #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71862824 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Mar 26, 2025
Summary: This should get rid of the `libtorch_cpu.so: undefined reference to `logf@GLIBC_2.27'` etc.. we see in our cpp unit tests on Github CI See: https://fb.workplace.com/groups/1405155842844877/permalink/23944202491846891/ Note there is another error of undefined reference with specific benchmark library - this will need a different fix. coming in next diff Differential Revision: D71862824
aporialiao
force-pushed
the
export-D71862824
branch
from
28caf61 to
7c4ab91
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71862824 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Mar 26, 2025
Summary: This should get rid of the `libtorch_cpu.so: undefined reference to `logf@GLIBC_2.27'` etc.. we see in our cpp unit tests on Github CI See: https://fb.workplace.com/groups/1405155842844877/permalink/23944202491846891/ Note there is another error of undefined reference with specific benchmark library - this will need a different fix. coming in next diff Differential Revision: D71862824
aporialiao
force-pushed
the
export-D71862824
branch
from
7c4ab91 to
33d273c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71862824 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Mar 26, 2025
Summary: This should get rid of the `libtorch_cpu.so: undefined reference to `logf@GLIBC_2.27'` etc.. we see in our cpp unit tests on Github CI See: https://fb.workplace.com/groups/1405155842844877/permalink/23944202491846891/ Note there is another error of undefined reference with specific benchmark library - this will need a different fix. coming in next diff Differential Revision: D71862824
aporialiao
force-pushed
the
export-D71862824
branch
from
33d273c to
2e1407d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71862824 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Mar 26, 2025
Summary: This should get rid of the `libtorch_cpu.so: undefined reference to `logf@GLIBC_2.27'` etc.. we see in our cpp unit tests on Github CI See: https://fb.workplace.com/groups/1405155842844877/permalink/23944202491846891/ Note there is another error of undefined reference with specific benchmark library - this will need a different fix. coming in next diff Differential Revision: D71862824
aporialiao
force-pushed
the
export-D71862824
branch
from
2e1407d to
b1ad02b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71862824 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Mar 26, 2025
Summary: This should get rid of the `libtorch_cpu.so: undefined reference to `logf@GLIBC_2.27'` etc.. we see in our cpp unit tests on Github CI See: https://fb.workplace.com/groups/1405155842844877/permalink/23944202491846891/ Note there is another error of undefined reference with specific benchmark library - this will need a different fix. coming in next diff Differential Revision: D71862824
aporialiao
force-pushed
the
export-D71862824
branch
from
b1ad02b to
bef8955
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71862824 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Mar 26, 2025
Summary: This should get rid of the `libtorch_cpu.so: undefined reference to `logf@GLIBC_2.27'` etc.. we see in our cpp unit tests on Github CI See: https://fb.workplace.com/groups/1405155842844877/permalink/23944202491846891/ Note there is another error of undefined reference with specific benchmark library - this will need a different fix. coming in next diff Differential Revision: D71862824
aporialiao
force-pushed
the
export-D71862824
branch
from
bef8955 to
bf03d39
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71862824 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Mar 26, 2025
Summary: This should get rid of the `libtorch_cpu.so: undefined reference to `logf@GLIBC_2.27'` etc.. we see in our cpp unit tests on Github CI See: https://fb.workplace.com/groups/1405155842844877/permalink/23944202491846891/ Note there is another error of undefined reference with specific benchmark library - this will need a different fix. coming in next diff Differential Revision: D71862824
aporialiao
force-pushed
the
export-D71862824
branch
from
bf03d39 to
9d67379
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71862824 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Mar 26, 2025
Summary: This should get rid of the `libtorch_cpu.so: undefined reference to `logf@GLIBC_2.27'` etc.. we see in our cpp unit tests on Github CI See: https://fb.workplace.com/groups/1405155842844877/permalink/23944202491846891/ Note there is another error of undefined reference with specific benchmark library - this will need a different fix. coming in next diff Differential Revision: D71862824
Summary: This should get rid of the `libtorch_cpu.so: undefined reference to `logf@GLIBC_2.27'` etc.. we see in our cpp unit tests on Github CI See: https://fb.workplace.com/groups/1405155842844877/permalink/23944202491846891/ Note there is another error of undefined reference with specific benchmark library - this will need a different fix. coming in next diff Differential Revision: D71862824
aporialiao
force-pushed
the
export-D71862824
branch
from
9d67379 to
f0d66ec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71862824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This should get rid of the
libtorch_cpu.so: undefined reference tologf@GLIBC_2.27'` etc.. we see in our cpp unit tests on Github CI See: https://fb.workplace.com/groups/1405155842844877/permalink/23944202491846891/Note there is another error of undefined reference - but it's related to our library not installing google benchmark rather than something inside of torch.so file like the ones mentioned in post.
Differential Revision: D71862824