Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch 2 Export Quantization for OpenVINO torch.compile backend #3321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
PyTorch 2 Export Quantization for OpenVINO torch.compile backend #3321
Changes from all commits
f0ab805
acf1647
5b1c99a
b2eaa82
810899a
82a47a5
26f044b
75d3549
e8e94d3
f09a85f
2c766e7
b424f92
f3137be
b7d2781
bb3c2f8
c093c76
090823f
0a422c2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for long term support, importing from
torchao.quantization.pt2e.quantize_pt2e
might be betterthis requires people to install torchao nightly though:
pip install --pre torchao --index-url https://download.pytorch.org/whl/nightly/cu126 # full options are cpu/cu118/cu126/cu128
but this can be done in a separate step since you might need to adapt your code to work with the torchao copy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
torch.export.export_for_training
is the recommended API now I thinkEdit: looks like in new pytorch versions these two are the same, in that case we might be recommending
torch.export.export
since it's simpler. cc @tugsbayasgalan @gmagogsfm to confirmThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I checked with Tugsuu, please continue to use
torch.export.export
, we'll be migrating to this as well