-
Notifications
You must be signed in to change notification settings - Fork 514
Disable running slow CI for doc-only changes #9072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ghpvnist
wants to merge
14
commits into
pytorch:master
Choose a base branch
from
ghpvnist:actions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okay I've done some testing on my fork. It should trigger the workflows when there are code changes. If PR only has markdown changes, it should return success early and skip running the actual tests. |
tengyifei
requested changes
May 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bhavya01
reviewed
May 1, 2025
@ghpvnist still not works:
|
e976214
to
ce72763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While getting #9065 reviewed, I noticed that we're running expensive (and long) CI even for no-op changes like removing trailing whitespaces from markdown files.
Note that this only skips CI when the entire PR only consists of markdown changes. Removing the CI for comments are more difficult. However, this is a step in the right direction to save some resources and enable merging PRs faster.
fixes #9073