Skip to content

Disable running slow CI for doc-only changes #9072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

ghpvnist
Copy link
Collaborator

@ghpvnist ghpvnist commented May 1, 2025

While getting #9065 reviewed, I noticed that we're running expensive (and long) CI even for no-op changes like removing trailing whitespaces from markdown files.

Note that this only skips CI when the entire PR only consists of markdown changes. Removing the CI for comments are more difficult. However, this is a step in the right direction to save some resources and enable merging PRs faster.

fixes #9073

@tengyifei
Copy link
Collaborator

Currently we require that the CPU and TPU tests must pass before a PR can be landed.

If these checks are skipped, will that prevent any markdown changes from landing, since GitHub checks would look like this:

screenshot-2025-04-30-17-46-33

@ghpvnist
Copy link
Collaborator Author

ghpvnist commented May 1, 2025

Okay I've done some testing on my fork. It should trigger the workflows when there are code changes. If PR only has markdown changes, it should return success early and skip running the actual tests.

@tengyifei tengyifei self-requested a review May 1, 2025 02:18
Copy link
Collaborator

@tengyifei tengyifei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The logic looks sensible to me, but looks like the workflow file has a syntax error:

screenshot-2025-04-30-23-59-53

@bhavya01 bhavya01 self-requested a review May 1, 2025 17:28
@tengyifei
Copy link
Collaborator

@ghpvnist still not works:

Invalid workflow file: .github/workflows/build_and_test.yml#L54
The workflow is not valid. .github/workflows/build_and_test.yml (Line: 54, Col: 9): Unexpected value 'secrets' .github/workflows/build_and_test.yml (Line: 44, Col: 5): Required property is missing: runs-on

@ghpvnist ghpvnist force-pushed the actions branch 16 times, most recently from e976214 to ce72763 Compare May 2, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable running slow CI for doc-only changes
3 participants