Fix + Run DynamicShapeDetector
tests on CI.
#9075
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamicShapeDetector
was introduced on #7918. However, it has the following issues:torch_xla.compile()
fromallowed_traces
tonum_different_graphs_allowed
. However, the tests weren't changes accordingly.assertRaises(RuntimeError, msg=msg)
. However,msg
was actually supposed to be the expected error.torch_xla.compile()
parameter name to the names used in the implementation, there was no standard. "Traces" and "graphs" were used interchangeably.This PR fixes the aforementioned issues by:
assertRaises
byassertRaisesRegex
max_different_graphs
everywhere