Skip to content

Fix + Run DynamicShapeDetector tests on CI. #9075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ysiraichi
Copy link
Collaborator

DynamicShapeDetector was introduced on #7918. However, it has the following issues:

  • The test never run on CI
  • Its last commit changed the parameter name of torch_xla.compile() from allowed_traces to num_different_graphs_allowed. However, the tests weren't changes accordingly.
  • The tests used the context manager assertRaises(RuntimeError, msg=msg). However, msg was actually supposed to be the expected error.
  • From the torch_xla.compile() parameter name to the names used in the implementation, there was no standard. "Traces" and "graphs" were used interchangeably.

This PR fixes the aforementioned issues by:

  • Adding the test to the run_tests.sh file
  • Replace assertRaises by assertRaisesRegex
  • Standardize the name to max_different_graphs everywhere
  • Prefer "graphs" to "traces"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant