Error Handling: refactor the existing ComputationClient implementations to use status QOL functions.
#9420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysiraichi
changed the title
ComputationClient implementations to use status QOL functions.
|
Blocked until #9419 is merged. |
ysiraichi
force-pushed
the
ysiraichi/status-for-computation-clients
branch
from
328870d to
5ef2bb3
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-pjrt-registry
branch
from
50d9c5a to
e1bf39d
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-computation-clients
branch
from
5ef2bb3 to
4873c0d
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-pjrt-registry
branch
from
e1bf39d to
2083d31
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-computation-clients
branch
from
4873c0d to
ee438d0
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-pjrt-registry
branch
from
2083d31 to
40db714
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-computation-clients
branch
from
ee438d0 to
fc8dcd5
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-pjrt-registry
branch
from
40db714 to
9ebf41c
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-computation-clients
branch
from
fc8dcd5 to
23263bf
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-pjrt-registry
branch
from
9ebf41c to
8499caf
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-computation-clients
branch
from
23263bf to
8ba721e
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-pjrt-registry
branch
from
a4b9bd4 to
c0e7506
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-computation-clients
branch
from
8ba721e to
df432d2
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-pjrt-registry
branch
3 times, most recently
from
c4595dc to
3c1289f
Compare
ysiraichi
force-pushed
the
ysiraichi/status-for-computation-clients
branch
from
df432d2 to
9c19b16
Compare
ysiraichi
changed the base branch from
ysiraichi/status-for-pjrt-registry
to
master
Update IFRT and PjRt computation clients to use `Create()` factory methods: - Replace constructors with factory methods that return `StatusOr<T>` - Use `ConsumeAndMaybeThrow` for `XlaCoordinator::Create` integration - Improved error handling with proper status propagation
ysiraichi
force-pushed
the
ysiraichi/status-for-computation-clients
branch
from
0af57e2 to
be08367
Compare
|
I will land this for now. @zhanyong-wan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
IfrtComputationClientandPjRtComputationClientin a similar way thatXlaCoordinatorwas modified in #9386, by:PrivateUsefor each of them, so as to make their constructor callable only in private contextsCreate()static member function that actually instantiates them, calling their constructorInitialize()member function that is called byCreate(), so as to initialize the class' members