Remove functions that throw status error. #9602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up: #9580
This PR finalizes the work that started with #9580 for replacing
OkOrThrow()
andGetValueOrThrow()
in favor of the macros introduced in #9588 (which were also part of that work). In summary, is the last one after:OkOrThrow()
andGetValueOrThrow()
with macros for throwing status errors. #9580: initial work that was broken down into the PRs belowtest
: Use new macros for throwing exceptions. #9590runtime
: Use new macros for throwing exceptions. #9591ops
: Use new macros for throwing exceptions. #9592torch_xla
: Use new macros for throwing exceptions (part 1). #9593torch_xla
: Use new macros for throwing exceptions (part 2). #9594init_python_bindings.cpp
: Use new macros for throwing exceptions. #9595aten_xla_type.cpp
: Use new macros for throwing exceptions. #9596Key Changes:
test/cpp/test_status_common.h
) Remove tests forOkOrThrow()
andGetValueOrThrow()
torch_xla/csrc/status.{h,cpp}
) Remove the implementation of those functions