Skip to content

Conversation

ysiraichi
Copy link
Collaborator

@ysiraichi ysiraichi commented Aug 28, 2025

Follow-up: #9580

This PR finalizes the work that started with #9580 for replacing OkOrThrow() and GetValueOrThrow() in favor of the macros introduced in #9588 (which were also part of that work). In summary, is the last one after:

Key Changes:

  • (test/cpp/test_status_common.h) Remove tests for OkOrThrow() and GetValueOrThrow()
  • (torch_xla/csrc/status.{h,cpp}) Remove the implementation of those functions

@ysiraichi ysiraichi merged commit 8fb90c8 into master Sep 2, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants