Skip to content

Conversation

@djhoese
Copy link
Member

@djhoese djhoese commented Dec 3, 2025

This is a rewrite/redo of #50 which was a redo of #48. After having this merged into main it was made apparent that the results produced by agg 2.4 inside aggdraw were not close enough to what was previously produced. Enough time had gone by that I thought "oh I'll just fix it eventually and then make a release"...

Well that never happened so I recently moved the maint/1.3 branch back to main and am now recreating this migration to agg 2.4 based on that new main branch. This was accomplished by cherry-picking 4 of the commits from #50.

TODO: I still need to review changes that were made to main after #50 was merged but were not backported to the maint/1.3 branch. These currently only live in the feat-agg24 branch on the pytroll/aggdraw repository. These PRs include:

All other changes since #50 seem to have been ported or are CI/maintenance related.

@djhoese djhoese added enhancement help wanted Primary maintainers may not have time to resolve this category: build dependencies Pull requests that update a dependency file labels Dec 3, 2025
@djhoese djhoese self-assigned this Dec 3, 2025
@djhoese
Copy link
Member Author

djhoese commented Dec 3, 2025

Ok #60 was re-added to main in #114. #87 and #78 were already backported. So now the only thing remaining (I think) is for me to rebase this PR to include #114 and then make it produce equivalent results. However, after a rebase I'm in no rush to fix the differing results.

dov added 4 commits December 3, 2025 10:02
- Move agg2 source directory to agg
- Update agg to 2.4
- Update aggdraw source to match and work with agg 2.4 interfaces
- Update tests to work with new code
@djhoese
Copy link
Member Author

djhoese commented Dec 3, 2025

@benburrill My latest commit changes the use of add_path from your newest rounded rectangle PR to concat_path which matches your old rounded_rectangle PR. Does that sound right to you?

@benburrill
Copy link
Contributor

For agg 2.4, yes. I changed it to add_path for the agg 2.2 backport because it didn't compile with concat_path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: build dependencies Pull requests that update a dependency file enhancement help wanted Primary maintainers may not have time to resolve this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants