-
Notifications
You must be signed in to change notification settings - Fork 45
Attempt to fix PyPy/CPython 3.8+ compatibility #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
djhoese
wants to merge
22
commits into
pytroll:main
Choose a base branch
from
djhoese:bugfix-dep-printfunc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move agg2 source directory to agg - Update agg to 2.4 - Update aggdraw source to match and work with agg 2.4 interfaces - Update tests to work with new code
# Conflicts: # CHANGELOG.md
Port of aggdraw to agg 2.4
Use array delete for point arrays
…troll#62) * Change default linejoin and linecap to preserve previous behavior * Change default line_cap from round_cap to butt_cap * Switch to ci-helpers workaround branch * Remove leftover copy/paste in appveyor config * Update tests for butt_cap default * Switch to strict conda channel priority for consistency * Switch to strict conda channel priority for consistency * Try removing CMD_IN_ENV use in appveyor * Try activating conda environment again * Add CMD_IN_ENV to environment activate because why not * Add CMD_IN_ENV to all test runs * Switch back to upstream ci-helpers tests * Remove unnecessary CMD_IN_ENV calls in appveyor * Add conda init for all possible shells on appveyor * Use conda run to execute python commands * Remove hopefully unnecessary conda init call * Switch travis back to upstream ci-helpers repository
Signed-off-by: odidev <[email protected]>
- error due to change in Python 3.10 C API
Fix "PY_SSIZE_T_CLEAN macro must be defined for '#' formats" error
ea9cc79 to
8f15b50
Compare
Member
Author
|
Ok turns out this is much harder than I thought. Here's what Cython says and we're a pure C++ module at this point: https://cython.readthedocs.io/en/stable/src/userguide/pypy.html This will just have to wait I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conda-forge has been trying for a long time to build a PyPy binary of aggdraw, but has been failing:
conda-forge/aggdraw-feedstock#25
The error is basically:
It turns out
printfuncis deprecated and unused, but was repurposed in Python 3.8:https://peps.python.org/pep-0590/#changes-to-the-pytypeobject-struct
I found a PR in swig that had to make the same type of update (swig/swig#2264) so I copied that simple logic here. Once merged I'll have to cherry-pick it to the
maintbranch so it can be released for the current stable version.I should be able to turn on PyPy wheel builds in CI too.