Various optimizations to colorspace code#143
Draft
djhoese wants to merge 5 commits intopytroll:mainfrom
Draft
Conversation
Also convert C constants to "#define" macros
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 91.18% 91.23% +0.04%
==========================================
Files 11 11
Lines 3847 3832 -15
==========================================
- Hits 3508 3496 -12
+ Misses 339 336 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@pnuu Looks like I was playing around with some dtype preservation in this PR too (specifically in colorize). I'll need to review this next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did a few little ones to allow a clearer path for the compiler to recognized clipping a value in one of the conversions to 0.0 and 1.0. The bigger update I did to have everything use a single memory view as input and output hopefully saves memory...maybe, but it doesn't seem to improve execution time which is surprising and extremely disappointing.
git diff origin/master **/*py | flake8 --diff(remove if you did not edit any Python files)