-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of basic flow of rebase function. #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @PranavTupe2000 ! Just some typos, can merge after that
@TheGupta2012 I have no idea why it's rendering the entire |
@ryanhill1 apparently, I see a I took the diff between the HEAD of this PR's branch and your commit 9ac826dc.
Note 1 : current PR was free of these changes in
Anyway, the point is that we will need to fix the EOL chars in some config file for |
Yeah sorry about @PranavTupe2000, I was trying to fix the formatting for you and didn't realize it would result in the EOL issue. You can always easily revert my commit! I won't touch it anymore 😅. Hopefully Harshit's EOL linter from #130 will allow an easy fix regardless, once merged. Apologies again, everyone! Thanks for figuring that out @TheGupta2012 |
No worries @ryanhill1 ! @PranavTupe2000 can you rebase with main and adjust the |
…feature-rebase-mvp Merging main into feature-rebase-main
No worries @ryanhill1, Thanks for helping me! Also thanks @TheGupta2012 for handling EOL issue. I will do the required changes. |
Hi @PranavTupe2000 , the |
#104
Fixes #116 #117 #118
Summary of changes
This PR contains implementation of a basic transformation prototype to convert an unrolled program into the specified target basis set.
rebase
would then change the basis set to one of the supported basis sets in pyqasm.