Conversation
- Hidden part of the token in logs to improve security. - Changed logging level for config from info to debug.
- Fixed the issue with retrieving the environment. - Updated logic to correctly fetch the environment settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the functionality and maintainability of the codebase. The most important changes include modifications to the
ApiConfigclass to implementJsonSerializable, updates to thegetEnvironmentmethod to use the correct API response structure, and adjustments to logging levels in theConfigLoaderclass.Improvements to
ApiConfigclass:src/Models/Config/ApiConfig.php: ImplementedJsonSerializableinterface and added ajsonSerializemethod to mask sensitive data in thetokenfield. [1] [2]Updates to API client:
src/Client/ApiClientV1.php: Modified thegetEnvironmentmethod to usegetEntitiesinstead ofgetResultfor iterating through environments and to compareenvNamewithgetSluginstead ofgetName.Logging adjustments:
src/Config/ConfigLoader.php: Changed the logging level frominfotodebugfor loaded configuration details.Documentation update:
README.md: Updated the description for theenvironmentconfiguration option to specify "Environment slug" instead of "Environment".Version bump:
composer.json: Updated the version from2.0.0to2.0.1.