Skip to content

Fix unsafe max context #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
I8dNLo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix unsafe max context #500

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2580059
Added check for max-context
Mar 20, 2025
779e9f9
Added check for max-context
Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions fastembed/common/preprocessor_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import json
from typing import Any
from pathlib import Path

import sys
import warnings
from tokenizers import AddedToken, Tokenizer

from fastembed.image.transform.operators import Compose
Expand Down Expand Up @@ -49,7 +50,15 @@ def load_tokenizer(model_dir: Path) -> tuple[Tokenizer, dict[str, int]]:
tokens_map = load_special_tokens(model_dir)

tokenizer = Tokenizer.from_file(str(tokenizer_path))
tokenizer.enable_truncation(max_length=max_context)

max_safe_length = min(max_context, sys.maxsize)
if max_context > sys.maxsize:
warnings.warn(
f"Requested max_context ({max_context}) exceeds system maximum integer size. "
f"Truncating to {sys.maxsize}.",
RuntimeWarning,
)
tokenizer.enable_truncation(max_length=max_safe_length)
tokenizer.enable_padding(
pad_id=config.get("pad_token_id", 0), pad_token=tokenizer_config["pad_token"]
)
Expand Down