-
Notifications
You must be signed in to change notification settings - Fork 0
update GetClusterEvents request and response #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…equest/response models
|
PR Packages Published Python Package:
NPM Package:
|
|
The latest Buf updates on your PR. Results from workflow Pull Request / linting (pull_request).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gBeridze994 when we ported this API we decided to make some changes regarding the legacy API to improve the usability and consistency of the API. I explained the reasoning behind these changes in my comments but happy to jump into a call to discuss more in detail.
# Conflicts: # gen/typescript/qdrant/cloud/monitoring/v1/monitoring_pb.d.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the PR doesn't include updates for the generated code.
Please make sure you've run the following commands from the root directory:
make generateOnce you've added them, you can dismiss this review.
Fix the GetClusterEvents request/response bodies to mirror http endpoint request/response