Zoom to bookmark extent #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manisandro
reviewed
Feb 28, 2024
manisandro
reviewed
Feb 28, 2024
plugins/Bookmark.jsx
Outdated
| resolveBookmark(bookmarkkey, (params) => { | ||
| const scale = parseFloat(params.s); | ||
| const zoom = MapUtils.computeZoom(this.props.mapScales, scale); | ||
| const center = params.c.split(/[;,]/g).map(x => parseFloat(x)); |
There was a problem hiding this comment.
Depending on urlPositionFormat in config.json, the url parameters may contain c and s, or e for extent. You might also want to handle the e case here.
There was a problem hiding this comment.
I think it is resolved with my new commit
benoitblanc
force-pushed
the
zoom-to-bookmark-extent
branch
from
9a8e558
to
84375bb
Compare
benoitblanc
force-pushed
the
zoom-to-bookmark-extent
branch
from
6963a1e
to
1f4003e
Compare
manisandro
reviewed
Feb 29, 2024
plugins/Bookmark.jsx
Outdated
| this.props.zoomToPoint(center, zoom, this.props.mapCrs); | ||
| } else if ('e' in params) { | ||
| const bounds = (params.e).split(',').map(n => parseFloat(n)); | ||
| this.props.zoomToExtent(bounds, this.props.mapCrs); |
There was a problem hiding this comment.
Sorry I forgot earlier, there is also the urlPositionCrs config option, which will add a crs URL parameter if urlPositionCrs is different than mapCrs. Something like params.crs ?? this.props.mapCrs should do.
There was a problem hiding this comment.
Thanks, I was not aware of these options
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR allows user to only zoom to a bookmark extent without changing theme or load/open the bookmark in the current window or new tab.
Thanks for the review
This feature has been funded by Grand Lyon Métropole https://www.grandlyon.com/