Add timestamp #947
Open
Add timestamp #947
+406
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snacj
reviewed
Dec 17, 2025
Collaborator
Snacj
left a comment
Snacj
left a comment
There was a problem hiding this comment.
Please address the comments and see if timestamps work on actual machines.
| // Assuming the graph's fixed Y-scale is from -1 to 1 based on the sine wave example | ||
| const graphMin = -1; | ||
| const graphMax = 1; | ||
| // TODO: For real-world graphs (like Winder), you might need to read the actual min/max scale |
Collaborator
There was a problem hiding this comment.
We can't assume that the min/max of the y axis will always be -1 and 1.
See roundness value of the laser (min: 0, max: 100)
|
|
||
| const graphEl = graphWrapperRef.current; | ||
| // The BigGraph component is the first child (the one with the actual chart) | ||
| // TODO: Find a better way to do this |
Collaborator
There was a problem hiding this comment.
If there is a better way to do it, please implement. Otherwise delete the comment.
Collaborator
There was a problem hiding this comment.
Please test the Graph on that machine. It may not work due to the y-axis limitation.
Collaborator
There was a problem hiding this comment.
Please test the Graph on that machine. It may not work due to the y-axis limitation.
Collaborator
|
@Snacj Please finish up this Issue asap, bach's internship is over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Able to add markers for timestamps and export in a new excel file. Can still improve with the code. The real scale from the Y axis of the graph is not done, right now only hard code.