Harmonize machines naming #985
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraemr
requested changes
Dec 18, 2025
Collaborator
kraemr
left a comment
kraemr
left a comment
There was a problem hiding this comment.
Remove the change i requested, otherwise looks good
Comment on lines
130
to
136
| } | ||
| let app_state_event = app_state.clone(); | ||
| let main_namespace = &mut app_state_event | ||
| let main_namespace = &mut app_state_event2 | ||
| .socketio_setup | ||
| .namespaces | ||
| .write() |
TheBest6337
force-pushed
the
harmonize-machines-naming
branch
from
c75fe8e to
ffdcf17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Harmonize naming of machines #939 is finished