perf: up deps

package.json

@@ -39,20 +39,20 @@
     "lodash.get": "^4.4.2",
     "lodash.uniq": "^4.5.0",
     "mkdirp": "^1.0.4",
-    "node-downloader-helper": "^2.1.5",
+    "node-downloader-helper": "^2.1.9",
     "progress": "^2.0.3",
     "read-pkg": "5.2.0",
-    "slugify": "^1.6.5"
+    "slugify": "^1.6.6"
   },
   "devDependencies": {
     "coveralls": "^3.1.1",
-    "eslint": "^8.28.0",
-    "eslint-config-standard": "^17.0.0",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-n": "^15.5.1",
+    "eslint": "^8.47.0",
+    "eslint-config-standard": "^17.1.0",
+    "eslint-plugin-import": "^2.28.0",
+    "eslint-plugin-n": "^16.0.1",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-promise": "^6.1.1",
-    "mocha": "^10.1.0",
+    "mocha": "^10.2.0",
     "mocha-sonarqube-reporter": "^1.0.2",
     "nyc": "^15.1.0"
   },

src/index.js

@@ -1,6 +1,7 @@
 const exec = require('child_process').execFile
 const log = require('fancy-log')
 const process = require('process')
+const assert = require('assert')
 const prepareExecEnvironment = require('./sonar-scanner-executable').prepareExecEnvironment
 const scannerExecutable = require('./sonar-scanner-executable').getSonarScannerExecutable
 const localscannerExecutable = require('./sonar-scanner-executable').getLocalSonarScannerExecutable
@@ -25,6 +26,8 @@ function scan(params, callback) {
 function scanCLI(cliArgs, params, callback = () => {}) {
   log('Starting analysis...')
 
+  assert.equal(typeof callback, 'function', `cb must be a function: ${callback}`)
+
   // prepare the exec options, most notably with the SQ params
   const optionsExec = prepareExecEnvironment(params, process)
 

src/sonar-scanner-executable.js

@@ -149,7 +149,6 @@ function getLocalSonarScannerExecutable(passExecutableCallback) {
     // TODO: we should check that it's at least v2.8+
     log('Local install of Sonarscanner found. Using it.')
     passExecutableCallback(command)
-    return
   } catch (e) {
     // sonar-scanner is not in the PATH
     throw Error('Local install of SonarScanner not found.')