Merged
Conversation
Signed-off-by: Daniel Vérité <dverite@gmail.com>
Get first the partition settings and key column type before creating the new partition. If these operations fail, do not create the partition, which avoids leaving the attachment in an unfinished state. Signed-off-by: Daniel Vérité <dverite@gmail.com>
When the query in ListPartitions() failed (for instance because of a timeout), the partition manager exited with an error code, but no relevant trace was emitted. This fix adds the logging of the SQL error. Signed-off-by: Daniel Vérité <dverite@gmail.com>
Signed-off-by: Daniel Vérité <dverite@gmail.com>
dverite
force-pushed
the
error-checking
branch
from
0d4482b to
800d28a
Compare
|
Collaborator
Author
|
#storage |
dcupif
approved these changes
Feb 26, 2026
Contributor
dcupif
left a comment
dcupif
left a comment
There was a problem hiding this comment.
LGTM
Thought on the side, it seems that we only have an auto-generated CHANGELOG for this project, but nothing tailored for humans. We may want to change that at some point 🤔
qfritz
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.