Skip to content

Release 7.2.0 #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SpertsyanKM merged 3 commits into from
Dec 20, 2025
+6 −6
Merged

Release 7.2.0 #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6305ca
[create-pull-request] automated change
SpertsyanKM Dec 20, 2025
efbc3c2
Check proxy url emptyness before setting it.
SpertsyanKM Dec 20, 2025
07b1a63
Couple of other emptyness checks
SpertsyanKM Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastlane/report.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@



<testcase classname="fastlane.lanes" name="0: default_platform" time="0.000991">
<testcase classname="fastlane.lanes" name="0: default_platform" time="0.000215">

</testcase>

Expand Down
4 changes: 2 additions & 2 deletions ios/sandwich/NoCodesSandwich.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class NoCodesSandwich: NSObject {
projectKey: String,
proxyUrl: String? = nil
) {
let noCodesConfig = NoCodesConfiguration(projectKey: projectKey, proxyURL: proxyUrl)
let noCodesConfig = NoCodesConfiguration(projectKey: projectKey, proxyURL: proxyUrl?.isEmpty == true ? nil : proxyUrl)

NoCodes.initialize(with: noCodesConfig)
NoCodes.shared.set(delegate: self)
Expand All @@ -46,7 +46,7 @@ public class NoCodesSandwich: NSObject {
NoCodes.shared.set(screenCustomizationDelegate: self)
}

if let contextKey = contextKey {
if let contextKey = contextKey, !contextKey.isEmpty {
screenPresentationConfigs[contextKey] = config
} else {
screenPresentationConfigs = [:]
Expand Down
6 changes: 3 additions & 3 deletions ios/sandwich/QonversionSandwich.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public class QonversionSandwich : NSObject {
config.setEntitlementsCacheLifetime(cacheLifetime)
}

if let proxyUrl = proxyUrl {
if let proxyUrl = proxyUrl, !proxyUrl.isEmpty {
config.setProxyURL(proxyUrl);
}

Expand Down Expand Up @@ -143,7 +143,7 @@ public class QonversionSandwich : NSObject {
}

@objc public func purchaseProduct(_ productId: String, offeringId: String?, completion: @escaping BridgeCompletion) {
guard let offeringId = offeringId else {
guard let offeringId = offeringId, !offeringId.isEmpty else {
return purchase(productId, completion: completion)
}

Expand Down Expand Up @@ -304,7 +304,7 @@ public class QonversionSandwich : NSObject {
completion(bridgeData, nil)
}

if let contextKey = contextKey {
if let contextKey = contextKey, !contextKey.isEmpty {
return Qonversion.shared().remoteConfig(contextKey: contextKey, completion: sandwichCompletion)
}

Expand Down