Expose cleanup and library load functions #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only reload if not already loaded
Calling load_library in any context should update the global _lib
Author
|
We could also perhaps add aliases to not break legacy code: _load_library = load_library
_cleanup = cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm working on publishing a lab automation interface that uses this package, thanks a lot for making it! For a GUI application, I find it important to be able to connect/disconnect from the hardware dynamically. While the architecture of APT doesn't allow a clean disconnect (APTCleanup removes all connections rather than a specific one), I still find it valuable to have this option, and have been using a poorly patched version of this library to achieve it.
Now that I'm working on making our automation suite more proper and public, I would love to make the library load / cleanup actions public members of this package's API, so that the monkey patch is not required to use my interface. The logic flow of the proposed changes basically just makes sure that the
_libvariable can be reused - let me know if you think this would work well!This is adjacent to #6, basically just making this a public API and making re-loading more graceful.