updates to install cmd #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--root can be used to specify the install root.
The create_if_not_exist(...) function will now create parent directories if they do not exists. Added call to create_if_not_exists(...) when installing executable.
qqiangwu
reviewed
Mar 29, 2025
qqiangwu
reviewed
Mar 29, 2025
qqiangwu
reviewed
Mar 29, 2025
qqiangwu
reviewed
Mar 29, 2025
Owner
|
Still, there are conflicts. Please resolve it first. |
Owner
|
It seems that cppship-examples will check after In addition, you'd better run cppship lint and fmt in advance in your env using llvm@19. |
Author
Yes, I have run both, but there were no warnings/changes on feat-install-cmd ❯ git status
On branch feat-install-cmd
Your branch is up to date with 'origin/feat-install-cmd'.
nothing to commit, working tree clean
on feat-install-cmd ❯ cppship lint
lint run clang-tidy
on feat-install-cmd ❯ cppship fmt
format run clang-format
format all files are formated
on feat-install-cmd ❯ git status
On branch feat-install-cmd
Your branch is up to date with 'origin/feat-install-cmd'.
nothing to commit, working tree clean
on feat-install-cmd ❯Perhaps cppship is not running them for some reason?, but there is no indication of any errors. |
Owner
cppship fmt -c HEAD~6
cppship lint -c HEAD~6
# run this for more options
cppship fmt -hBy default, fmt and lint only runs against uncommitted files. |
Owner
In CI, the following commands are executed: mergebase=$(git merge-base --fork-point origin/${{github.event.pull_request.base.ref}})
cppship build -d
cppship fmt -c ${mergebase}
cppship lint -c ${mergebase} |
Author
Ah, OK. |
Author
|
running The call to most (maybe all?) of the other warnings are in files I haven't modified. Does it lint clean on your machine? I compiled llvm 19.1.7 from source and used Lmod to configure load it into my environment because clang-15 is the newest version on Ubuntu 22.04. What should I do here? |
Owner
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for creating the install destination, giving a user-defined install directory with
--rootoption, and changes the default install directory to~/.cppship/bin.