Calls order of q_invokable method #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Santhosh Kumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
commit : 1f51dc2 introduced a way to share custom easing curve objects among different animations. However, the easingCurve type was not constructed properly leading to the animation falling back to linear easing. Change-Id: I5a0ce2bd513ba2c24f9554a46547c479f2a2d021 Reviewed-by: Eirik Aavitsland <[email protected]>
It's redundant as the class name is QQStyleKitPropertyFont. Also this makes it consistent with the palette API. Change-Id: Ic334c1febb1cdfb5cb09f898cb2f27ecb06c1c1f Reviewed-by: Richard Moe Gustavsen <[email protected]>
Change-Id: I3594798dfb475118cad046948ccc4fe180bbd9a3 Reviewed-by: Richard Moe Gustavsen <[email protected]>
Change-Id: I0177d20c381d83d2a816199a89b6fc9150fa4766 Reviewed-by: Richard Moe Gustavsen <[email protected]>
Change-Id: I8a7fc86482e2083a24d1e7159737fd0ababc8e0b Reviewed-by: Richard Moe Gustavsen <[email protected]>
Change-Id: Ie23d3dfc1a93d052e9a19c9151c5ede4afee5ea9 Reviewed-by: Richard Moe Gustavsen <[email protected]>
[ChangeLog][QtQuick.Shapes.DesignHelpers] Added StarShape. Fixes: QTBUG-141531 Change-Id: Ifcce36d3bbac7f59612c3d056e8bcbbcea034137 Reviewed-by: Jan Arve Sæther <[email protected]>
[ChangeLog][QtQuick.Shapes.DesignHelpers] Added RegularPolygonShape Fixes: QTBUG-141530 Change-Id: Ifc1b9d54cb89f90d8032e44e269e6207c4e2d87f Reviewed-by: Jan Arve Sæther <[email protected]>
Properly clear the event receiver whenever a new profiler client is attached to it and check for the exact number of expected events to avoid analyzing partial results. Task-number: QTBUG-142361 Change-Id: Iec12e2ae6dccaa100dcd3c92a17ba2c02e70eb2c Reviewed-by: Sami Shalayel <[email protected]>
Since 1919410, rejecting should be done with REJECT. Amends c7d5375 Change-Id: I6d83cedf7944d90d33ba388c7963f394d4ba153c Reviewed-by: Ulf Hermann <[email protected]>
A dialog button box is not a list of page tabs, but it groups the buttons, so use QAccessible::Grouping for the accessible role like the QDialogButtonBox equivalent in qtbase does (see QAccessibleDialogButtonBox). Fixes: QTBUG-141734 Pick-to: 6.10 Change-Id: I5ce474fbf6902c7e565f86307d00a0b8bdc63abd Reviewed-by: Volker Hilsheimer <[email protected]>
This adds support for the feColorMatrix, feOffset and feFlood filters. We also need to change how we calculate the bounds of post-processed items to use the internal bounds. Basically, we need the bounds of the children of the item + the item itself before the node's transform is applied. This is because the bounding box is axis aligned, so we cannot get the original rectangle back just by applying the inverse transform in the case of e.g. rotations. Task-number: QTBUG-121541 Change-Id: I7a8863bef4397df4043c854256dca312b91f888a Reviewed-by: Eirik Aavitsland <[email protected]> Reviewed-by: Hatem ElKharashy <[email protected]>
This introduces chaining post-processing effects, and the feComposite and feBlend nodes to allow compositing these. Task-number: QTBUG-121541 Change-Id: Ib2aa99139869814a575a2bf9d9e6319b31828285 Reviewed-by: Eirik Aavitsland <[email protected]> Reviewed-by: Hatem ElKharashy <[email protected]>
We support merging up to 8 effects for now. Task-number: QTBUG-121541 Change-Id: Ic60400f054700e4ff44452870770b2175834dd85 Reviewed-by: Eirik Aavitsland <[email protected]>
We no longer support it. Change-Id: I4244f251f4fb8f3b2d93d1d0a12bc4bba68b931e Reviewed-by: Ulf Hermann <[email protected]>
The revision change does not break qqmlpropertycache but will cause static_asserts failures while the patch adapting to the moc change is not merged. Temporarily allow for both revision and revert to 14 only as soon as poosible. Task-number: QTBUG-142186 Change-Id: I4ea37bff08f0780148ec7f8958a05f372a6df0f3 Reviewed-by: Ulf Hermann <[email protected]>
This patch adds corresponding - VirtualKeywordRegion and OverrideKeywordRegion - isVirtual and isOverride members to Dom::PropertyDefinition adjusts the corresponding PropertyDefinition::writeOut method and introduces a test for the PropertyDefinition structure, currently covering / focusing only on the functionality relevant to the scope of this patch Note: maybe it is a good idea from now on to use newly added tests/auto/qmldom/elements directory for the tests covering qqmldomelements_p.h Task-number: QTBUG-98320 Change-Id: Ifac60d3e52900605778afaf3819a9af46c97954a Reviewed-by: Sami Shalayel <[email protected]>
This patch introduces corresponding QmlVirtualProperty and QmlOverrideProperty modifiers and expands the highlight of the PropertyDefinition Task-number: QTBUG-98320 Change-Id: If1cd98b9958ed3be5fd67e02abb71ca6fa68da6b Reviewed-by: Olivier De Cannière <[email protected]>
This patch adds support for the completions of newly introduced keywords and corresponding valid combinations. Change-Id: I9c3b008405ac4fd45d7393013838df0813426358 Reviewed-by: Sami Shalayel <[email protected]>
This patch adds two new fields, IsVirtual and IsOverride, to CompiledData::Property. These fields will later be used to populate QQmlPropertyData and to handle property override semantics. At a high level, this change focuses on the data flow from the AST to the IR, laying the groundwork for future semantic resolution. Also moves test helper Syntax namespace to the quicktestutils Task-number: QTBUG-98320 Change-Id: Ic2a2e28df08d53c8752c49304bd5f7ff46916d08 Reviewed-by: Fabian Kosmale <[email protected]>
Currently Override semantics evaluation is based on the flags of QQmlPropertyData. Therefore adding this flags is necessary. On a bigger picture this patch focuses on the data flow from the IR to QQmlPropertyData (property cache) Change-Id: I206ee46a075675e37c35e4c72c74c68e132d2ef2 Task-number: QTBUG-98320 Reviewed-by: Ulf Hermann <[email protected]>
Add some asserts to avoid calling methods from the wrong thread (this only seems to happen in the tst_qmlls_qqmlcodemodel tests, not in qmlls itself). Also make the methods private to avoid this from happening again. Adapt the tests to call the right methods, and to wait for the QQmlCodeModel file loading thread to finish (by waiting on the newly added openUpdateThreadFinished signal). This fixes the flakines from tst_qmlls_qqmlcodemodel reloadLotsOfFiles, where a data race, caused by the test calling one of QQmlCodeModels function in the wrong thread, was making the test flaky. Pick-to: 6.10 Fixes: QTBUG-142264 Change-Id: I6d6b89674344f271e94e6e558a34dd6900cfe703 Reviewed-by: Semih Yavuz <[email protected]>
Add missing import paths where needed to silence all the import path warnings from tst_qmlls_qqmlcodemodel. Change-Id: Ia667a381ca01c8b1dc32387e1b1e5bb633ef54e6 Reviewed-by: Semih Yavuz <[email protected]>
Write qrc file paths to the .qmlls.build.ini. This ensures that qmlls doesn't pick up other modules .qrc files to avoid situations like QTBUG-141707. Fixes: QTBUG-141707 Change-Id: I4ea6756af7b12bf00e2f3f3338c0d5bfd792dc77 Reviewed-by: Alexandru Croitor <[email protected]>
Instead of writing each line via an "echo" command, collect all target specific .ini bits into a file, and then append that file into the .qmlls.build.ini file. Note that writing the .ini bits directly into .qmlls.build.ini is not possible because add_custom_command() eats away the newlines from its arguments. Change-Id: Ibc79aa69e227b1b46459109fd055a0e0dfe8b96c Reviewed-by: Joerg Bornemann <[email protected]>
We need to set the value before the early return for anonymous types. Amends b0bf54b Task-number: QTBUG-142186 Change-Id: Ib205aba54bed2da4e414ff0422152bb50b7a8530 Reviewed-by: Ulf Hermann <[email protected]>
Change-Id: If9f56ce236bcd1c33429e4bfac29fef5b9a7bfd7 Reviewed-by: Ulf Hermann <[email protected]>
And use it to store metaObjectHashes using the more efficient QHash instead of QMap. QAnyStringView does not come with an implementation of qHash. Introduce one that is good enough for our needs within qqmltyperegistrar. In order to not pollute resolutions in other parts of the codebase, it should not be exposed elsewhere. Amends f2c8f2b Task-number: QTBUG-142186 Change-Id: I9b7023dc5df49e18687ae26442e4a30d11bb2681 Reviewed-by: Ulf Hermann <[email protected]>
Move the check for wayland after the position check and convert the qDebug() message as a comment. Only check if the platform is wayland when position check fails. Remove the qDebug output to reduce noise in automated tests runs, retain that information as a comment. Change-Id: Ie0cd96ac15ef03f2cb52d6c6bf3fdb3d9cec9beb Reviewed-by: Ulf Hermann <[email protected]>
The merge at 2bee46e incorrectly resolved the conflict around Chunk::sweep. It had been changed by d53b07e Change-Id: I048bafcedbf23fc8d76e0093e11a67207d56a9c8 Reviewed-by: Semih Yavuz <[email protected]>
We need this method in LinterVisitor in a later commit, so move it to the utils. Change-Id: Ia93357df1663c16723afe2bcdfbd3c2f6df6ce4c Reviewed-by: Olivier De Cannière <[email protected]>
Allow to create qml snippets that start with pragma, by not using the template on snippets starting with pragma. Pick-to: 6.10 6.11 Task-number: QTBUG-142455 Change-Id: I381c28181c9d77e7298c722038487fdcb9fe7e99 Reviewed-by: Olivier De Cannière <[email protected]>
Its in use, says the profiler, and completely unreadable. Split the method up in smaller parts. Task-number: QTBUG-142522 Change-Id: I6cd8860b28335605fb7a34fb1fc62aac2c55baa4 Reviewed-by: Ulf Hermann <[email protected]> Reviewed-by: Dmitrii Akshintsev <[email protected]>
Its in use, says the profiler, and completely unreadable. Split it the method up in smaller parts. Task-number: QTBUG-142522 Change-Id: I3e4adcab3fc554229385268555772dddd4bd3ffc Reviewed-by: Fabian Kosmale <[email protected]> Reviewed-by: Dmitrii Akshintsev <[email protected]> Reviewed-by: Ulf Hermann <[email protected]>
Its in use, says the profiler, and completely unreadable. Split the method up in smaller parts. The usages of the enum to string map looks weird, invert the keys and values to avoid iterating over the map when parsing strings to lookuptypes. Task-number: QTBUG-142522 Change-Id: I02977cacb93df9259f9aab9cf0858f7f7472e7c8 Reviewed-by: Fabian Kosmale <[email protected]> Reviewed-by: Ulf Hermann <[email protected]>
The "fix" part is redundant. QQmlSA is still in tech preview. [ChangeLog][QML][QQmlSA] The fixDescription on a QQmlSA::FixSuggestion has been renamed to description. Change-Id: I8f94ddb4e8dfe7c58600d3d0944eca2c041cb726 Reviewed-by: Sami Shalayel <[email protected]>
It was barely used and serve no additional purpose than the description. QQmlSA is still in tech preview. [ChangeLog][QML][QQmlSA] The member QQmlSA::FixSuggestion::hint has been removed. It was unused. Change-Id: Idfd032ed6299cc74cedb4aed4f060d8c9a4bf912 Reviewed-by: Sami Shalayel <[email protected]>
This way we have a single source of truth and we reduce duplication. QQmlSA is still in tech preview. Change-Id: I37e6cd62d9b84b2d4a277a8923d9c087b2e33d94 Reviewed-by: Sami Shalayel <[email protected]>
Since the same QMetaType can map to multiple QQmlPropertyCaches, when checking whether we can assign a QObject to a property, the best thing we can do right now is consider all options. This is actually too fuzzy since the types described by the QQmlPropertyCaches can indeed be different, depending on type loader configuration. However, this is a fundamental problem we have to solve by restructuring the whole type registry. This change merely fixes the regression introduced by commit d6eb00f and is needed to make the latter pass on 6.10 and earlier. Pick-to: 6.11 6.10 6.8 Change-Id: I3e8cecfb892be237d80f1c1b49b29e4518a85381 Reviewed-by: Olivier De Cannière <[email protected]>
We employ the ConstructInPlace metacall for this, and ConstructInPlace expects to construct into uninitialized memory. Our CallArgument, however, always holds initialized memory. The actual fix is to remove all of CallMethod and its friends and replace it with QV4::convertAndCall() where we can easily customize the initialization behavior. However, doing so will be a rather substantial change with some noticable side effects. This change is a minimally invasive fix that can be picked back to older branches. We simply destruct the return value again before calling ConstructInPlace. It is somewhat dangerous because formally the space allocated for the return value is owned by QVariant and QVariant expects to always hold initialized memory. However, in this particular case we can get away with it because the memory is re-initialized right away, before the QVariant gets to see it again. Amends commit f62adc9. Pick-to: 6.11 6.10 6.8 Change-Id: I59af78ec36ea18d64c97286f0d6898b312d35617 Reviewed-by: Olivier De Cannière <[email protected]>
Otherwise coverity assumes they are copied. Coverity-Id: 899063 Change-Id: I4804addb200d3651baf8ee92c6ef906303e3c22a Reviewed-by: Olivier De Cannière <[email protected]>
After the deadlock fix in QTBUG-139211, these can be enabled again since they were crashing for the same reason. Pick-to: 6.10 6.11 Fixes: QTBUG-107028 Change-Id: I59141b07ebb7c698abbfee7b6b46225bdbf05838 Reviewed-by: Mitch Curtis <[email protected]>
The behavior was determined and documented in several related patches: 831efa1 e3a8d81 843b8d1 e32b292 But it's a bit confusing that most handlers are disabled when the parent is disabled, but not HoverHandler. Also fix QQuickPointerHandler::enabled doc indentation as a drive-by. Task-number: QTBUG-30801 Task-number: QTBUG-130899 Pick-to: 6.5 6.8 6.10 6.11 Change-Id: I62ee1bc7e6105d8038c3513931d146ec147fe20b Reviewed-by: Oliver Eftevaag <[email protected]>
Since QVector is just an alias, let's finally do what we could have done for Qt 6.0. Pick-to: 6.11 Change-Id: Ia9dbc8ecf4f099339cf7639acb22c14b24fa680b Reviewed-by: Sami Shalayel <[email protected]>
This actually checks that the button was clicked. Task-number: QTBUG-140930 Pick-to: 6.11 Change-Id: I086107d0d70a192049f6a3b400f6f933a7870edc Reviewed-by: Oliver Eftevaag <[email protected]>
Task-number: QTBUG-35598 Pick-to: 6.11 Change-Id: Ib57478974c0a3e3d750c1967375bcc9332d9d12c Reviewed-by: Richard Moe Gustavsen <[email protected]>
[ChangeLog][Controls] SpinBox now provides a ContextMenu by default. If you already have a custom context menu for it, ContextMenu will not open its own on e.g. right click. Task-number: QTBUG-140930 Pick-to: 6.11 Change-Id: I164b33918c575a26163436e83ffb5cdf3a715bd8 Reviewed-by: Richard Moe Gustavsen <[email protected]>
[ChangeLog][Controls] ComboBox now provides a ContextMenu by default. If you already have a custom context menu for it, ContextMenu will not open its own on e.g. right click. Task-number: QTBUG-140930 Pick-to: 6.11 Change-Id: I4abc476d3c7ae93cfdafe9b66e91b7eb49a41a4e Reviewed-by: Richard Moe Gustavsen <[email protected]>
[ChangeLog][Controls] SearchField now provides a ContextMenu by default. If you already have a custom context menu for it, ContextMenu will not open its own on e.g. right click. Task-number: QTBUG-140930 Pick-to: 6.11 Change-Id: I08475686bdc6e07891c7cd4cf05a8247ebfb518b Reviewed-by: Richard Moe Gustavsen <[email protected]>
[ChangeLog][Controls] DoubleSpinBox now provides a ContextMenu by default. If you already have a custom context menu for it, ContextMenu will not open its own on e.g. right click. Task-number: QTBUG-140930 Pick-to: 6.11 Change-Id: I1d55903b04fc457ed53cc76b12b3ec9bcf226947 Reviewed-by: Richard Moe Gustavsen <[email protected]>
This fixes the context menu being incorrectly positioned for all text editors. Fixes: QTBUG-142440 Pick-to: 6.11 Change-Id: I85e78839327ad7488f549eab46c7c19e88abd06c Reviewed-by: Richard Moe Gustavsen <[email protected]>
This happens when running all tests on macOS:
FAIL! : tst_QQuickContextMenu::Basic::mouseAreaUnderTextArea() Received a warning that resulted in a failure:
Mouse event at 265, 486 occurs outside target window (400x400).
Loc: [/Users/mitch/dev/qt-dev2/qtbase/src/testlib/qtestmouse.h(74)]
The easiest fix is to ensure that the context menu fits within the main
window.
Pick-to: 6.11
Change-Id: Ica17fb5fdc7ad1be1bb72e29b64f8b613f77c861
Reviewed-by: Richard Moe Gustavsen <[email protected]>
Otherwise we get a crash due to the missing null pointer check in QQuickDeliveryAgentPrivate::contextMenuTargets. I'm not sure what the correct fix is there, so work around it in the test. Amends 31ca393 Pick-to: 6.10 6.11 Change-Id: Ieb51215eb64433ef228f1d5985731d956a504b0c Reviewed-by: Richard Moe Gustavsen <[email protected]>
This is stricter and hence allows less mistakes. Pick-to: 6.11 Change-Id: Ief9eac68e12ac6afdc9288dde92ca37d6b9a7375 Reviewed-by: Richard Moe Gustavsen <[email protected]>
We don't support it yet. Task-number: QTBUG-134798 Pick-to: 6.11 Change-Id: Ib65815e638bed315f4174a1da75754ebc4b815a8 Reviewed-by: Richard Moe Gustavsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are 2 or more methods with the same name but reciving diferent arguments the QJSEngine Pickup the First One declared.
Example:
methodxyz(string)
methodxyz(objptr*)
It picks up the first one passing as argument a string and not the one that i was expecting an object as it was send.