Feat: refactor nic attribute workflows#526
Merged
grafuls merged 8 commits intoquadsproject:developmentfrom Apr 21, 2026
Merged
Conversation
* Always be DRY'ing Helper 1: _extract_job_id_from_response() Helper 2: _verify_job_scheduled() Helper 3: _monitor_and_verify_attribute_job()
* We think intel XX710 may not be able to do 128 VRF * Add proper warning but don't fail.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #526 +/- ##
===============================================
+ Coverage 92.53% 92.92% +0.38%
===============================================
Files 8 8
Lines 2533 2614 +81
===============================================
+ Hits 2344 2429 +85
+ Misses 189 185 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Don't obesess over defensive / firmware status handling
grafuls
requested changes
Apr 21, 2026
| return None | ||
| except (AttributeError, ValueError, KeyError) as e: # pragma: no cover | ||
| # Defensive: headers.get() raising exceptions is extremely rare in practice | ||
| if warn_on_missing: # pragma: no cover |
Collaborator
There was a problem hiding this comment.
all the # pragma comments after the excluded except are not necessary
Collaborator
There was a problem hiding this comment.
we should be using the new _extract_job_id_from_response method here as well
* try not to go too crazy with pragma no cover
grafuls
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three helper methods:
handle exceptions better
provide better job and polling monitoring
warn on Intel XX710 for firmware or hardware limitations avoid any confusion
1-2% test coverage added
Add graceful quit and instructions if VirtualizationMode is set to NONE but user wants to make a nic attribute change for SRIOV that depends on it, otherwise we get nasty 500 errors with no guidance.
closes: #523