Skip to content

Sync Development Changes#527

Merged
grafuls merged 35 commits intomasterfrom
development
Apr 22, 2026
Merged

Sync Development Changes#527
grafuls merged 35 commits intomasterfrom
development

Conversation

@sadsfae
Copy link
Copy Markdown
Collaborator

@sadsfae sadsfae commented Apr 21, 2026

  • Fix --export-scp hang bug
  • Add --wait to --racreset and upped retries to 30 from 15 for slower idracs
  • Add --insecure flag and support SSL verification
  • Add --version to CLI - thanks @mmahut
  • Major refactor of --set-nic-attributes to include covering attempts to push Intel XX710 beyond allowed VRF
  • Add half a dozen helper functions for improvements

fixes: #523
fixes: #498
fixes: #499
fixes: #450
fixes: #525

sadsfae and others added 30 commits April 15, 2026 23:40
* export_scp method polling loop 'continue' statement was
nested inside an unnecessary 'else:' block after the timeout check.
This made the control flow inconsistent with the working import_scp() method.

fixes: #499
fixes: #499
fixes: #498

* We now properly check SSL connections and offer an --insecure
  parameter.
*  export_scp hang bug: Fixed by discovering that Dell iDRAC
API endpoints (both Tasks and Jobs) return stale/cached status
data showing "Running" indefinitely even after the job
* Add more fixes for --export-scp feature
* Workaround: Instead of unreliable polling, we now wait 45 seconds
which is more than enough time then fetch json.
* This now fully works and is fast.

- INFO     - Job for exporting server configuration successfully created. Job ID: JID_763636328050
- INFO     - Waiting for export job to complete (typically takes 15-30 seconds)...
- INFO     - SCP export completed successfully.
- INFO     - Exported system configuration to file: ./2026-04-16_142201_targets_IDRAC-BIOS_export.json
- INFO     - Job for exporting server configuration successfully created. Job ID: JID_763636328050
- INFO     - Waiting for export job to complete (typically takes 15-30 seconds)...
- INFO     - SCP export completed successfully.
- INFO     - Exported system configuration to file: ./2026-04-16_142201_targets_IDRAC-BIOS_export.json

real	0m57.349s
user	0m0.409s
sys	0m0.066s
…aching bug

* making additional fixes here and testing, we were good but tinkered
  too much with control flow mechanisms
* revert back to a less aggress and simpler approach
fix/feat: --export-scp hang bug and add SSL validation
* Always be DRY'ing

Helper 1: _extract_job_id_from_response()
Helper 2: _verify_job_scheduled()
Helper 3: _monitor_and_verify_attribute_job()
* We think intel XX710 may not be able to do 128 VRF
* Add proper warning but don't fail.
* Don't obesess over defensive / firmware status handling
* try not to go too crazy with pragma no cover
Feat: refactor nic attribute workflows
chore: black fixes and flake8
sadsfae and others added 5 commits April 21, 2026 19:14
* essentially 2.7 minutes may not be enough time to poll idrac (15x
  retries).  Increasing this to 30 retries or just over 5min.
feat: add --wait to racreset
Resolves #525.

(cherry picked from commit fdd7b1d)
feat: add --version flag to CLI
@grafuls grafuls merged commit 612937a into master Apr 22, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants