Skip to content

feat: add --version flag to CLI#530

Merged
sadsfae merged 1 commit intoquadsproject:developmentfrom
mmahut:master
Apr 22, 2026
Merged

feat: add --version flag to CLI#530
sadsfae merged 1 commit intoquadsproject:developmentfrom
mmahut:master

Conversation

@mmahut
Copy link
Copy Markdown
Contributor

@mmahut mmahut commented Apr 22, 2026

Resolves #525.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally before submission?

@mmahut mmahut changed the base branch from master to development April 22, 2026 08:21
Comment thread CHANGELOG.md
@@ -1,6 +1,111 @@
# CHANGELOG
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be pulled in at all, it's solely managed by Github Actions and semantic versioning.

Comment thread src/badfish/__init__.py Outdated
@@ -1 +1 @@
__version__ = "1.1.1"
__version__ = "1.2.0"
Copy link
Copy Markdown
Collaborator

@sadsfae sadsfae Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be pushing this at all either, this is updated via semantic versioning too.

https://github.com/redhat-performance/badfish/blob/master/.github/workflows/production-release.yml

Then this is synced back to development.

https://github.com/redhat-performance/badfish/blob/master/.github/workflows/sync-back.yml

Copy link
Copy Markdown
Collaborator

@sadsfae sadsfae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello my old friend and thanks for the PR. Just a few minor things to drop from scope.

Resolves quadsproject#525.

(cherry picked from commit fdd7b1d)
@mmahut
Copy link
Copy Markdown
Contributor Author

mmahut commented Apr 22, 2026

Hello my old friend. Sorry, Github rebased it, force pushed the correct branch now.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.00%. Comparing base (e1516e6) to head (215d1ea).
⚠️ Report is 3 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #530   +/-   ##
============================================
  Coverage        93.00%   93.00%           
============================================
  Files                8        8           
  Lines             2644     2646    +2     
============================================
+ Hits              2459     2461    +2     
  Misses             185      185           
Flag Coverage Δ
unittests 93.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sadsfae sadsfae merged commit 1cdf5f9 into quadsproject:development Apr 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFE] Add a simple --version check

2 participants