camx: revision update for Lemans, Talos,Kodiak - #2961
camx: revision update for Lemans, Talos,Kodiak#2961Ganesh Khose (gkhose-qipl) wants to merge 6 commits into
Conversation
|
While we don't need opengl in DEPENDS anymore, it would probably make sense to have them as runtime recommendation (we have for virtual-opencl-icd, but while there is virtual-egl-icd in qcom-adreno, I don't think mesa has it, so it would have to be added there first). What about hamoa? Header was updated, but hamoa was not. |
Test Results 117 files + 3 698 suites +28 16h 25m 23s ⏱️ + 5h 2m 42s For more details on these failures, see this check. Results for commit abffebc. ± Comparison against base commit cf4acfb. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
| @@ -42,19 +37,6 @@ do_install:append() { | |||
|
|
|||
| cp -r ${S}/usr/lib/* ${D}${libdir} | |||
|
|
|||
| # Remove OpenCL-dependent libraries when opencl is not enabled. | |||
There was a problem hiding this comment.
Why? What happened?
There was a problem hiding this comment.
Why? What happened?
Because it was a compile-time dependency, it had to be compiled, and that compilation was failing. We used to remove libs/binaries if opencl/opengl was not available, but now that we are using dlopen, we can package them every time.
| ${libdir}/camx/${PLATFORM}/libmctf_cl_program.bin \ | ||
| " | ||
| FILES:${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'opencl', '${CAMX_OPENCL_FILES}', '', d)}" | ||
| FILES:${PN} += "${libdir}/camx/${PLATFORM}/libmctf_cl_program.bin" |
There was a problem hiding this comment.
What about ${libdir}/camx/${PLATFORM}/*.cl?
There was a problem hiding this comment.
What about
${libdir}/camx/${PLATFORM}/*.cl?
.cl files are not created now.
There was a problem hiding this comment.
Is it mentioned in the commit message?
| SRC_URI[chicdk.sha256sum] = "e2c276f278ccdb38cb1ccea120e7a84417b671760e566d5234c45933abee12a7" | ||
| SRC_URI[camxcommon.sha256sum] = "e048dd98f96807ff34dd54651b8ba045a057d6c1d0aa49cfc658ff256f79441f" | ||
|
|
||
| RRECOMMENDS:${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'opencl', 'virtual-opencl-icd', '', d)}" |
There was a problem hiding this comment.
But not for the other targets?
There was a problem hiding this comment.
But not for the other targets?
It was present in the other targets; it was only missing in Talos.
hamoa will open a follow-up PR. We saw a regression for hamoa, so it wasn’t included in this PR. We’re prioritizing the fix and working to bring hamoa back to tip. |
fdab6a6 to
208292c
Compare
208292c to
df83026
Compare
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
camxlib-kodiak: Update to the 1.0.27 revision
https://github.com/qualcomm-linux/meta-qcom/blob/master/CONTRIBUTING.md?plain=1#L27
df83026 to
34e53a2
Compare
|
Once e2e testing is complete, I’ll open it. |
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Doesn't build:
ERROR: camxlib-lemans-1.0.38-r0 do_package: QA Issue: camxlib-lemans: Files/directories were installed but not shipped in any package:
/usr/bin
/usr/bin/nhx.sh
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
camxlib-lemans: 2 installed and not shipped files. [installed-vs-shipped]
34e53a2 to
5a5f42f
Compare
Yes, we’ll validate it today, request early comments, and moved the PR to draft since it was not validated. |
5a5f42f to
3c1f746
Compare
|
Still failing to build: |
3c1f746 to
318b4e4
Compare
was not able to repo with with below steps. but updated patch to only copy hamoa |
The build logs contained exact description of the failing setup. Have you tried reproducing it? |
I didn’t get time to check yesterday since I was OOO, but I will review it today and provide an update. A similar issue was seen earlier with eSDK generation, so I updated the patch based on that observation, and the CI job indicates it worked. |
|
Observing camera regression on RB8_Prop [Info] Test Summary: Total Tests: 3 DUMP_DIR does not exist: /var/cache/camera/nativehaltest Axiom Job : https://axiom.qualcomm.com/#/reports/job/38773267 |
|
Ok. Note, this is still marked as a draft |
318b4e4 to
6d65cd0
Compare
|
|
6d65cd0 to
abffebc
Compare
Sorry, my local changes hadn’t been pushed, and since I pushed with -u, the new version file wasn’t updated. |
|
Dmitry Baryshkov (@lumag) / Ricardo Salveti (@ricardosalveti) can you please review |
| https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/camx.qclinux.0.0/${PBT_BUILD_DATE}/prebuilt_yocto_${PBT_BRANCH}/chicdk-${PLATFORM}_${PV}_armv8-2a.tar.gz;name=chicdk \ | ||
| https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/camx.qclinux.0.0/${PBT_BUILD_DATE}/prebuilt_yocto_${PBT_BRANCH}/camxcommon-${PLATFORM}_${PV}_armv8-2a.tar.gz;name=camxcommon \ | ||
| https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/camx.qclinux.0.0/${PBT_BUILD_DATE}/prebuilt_yocto_${PBT_BRANCH}/camxtest-${PLATFORM}_${PV}_armv8-2a.tar.gz;name=camxtest \ | ||
| https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/camx.qclinux.0.0/${PBT_BUILD_DATE}/prebuilt_yocto_${PBT_BRANCH}/camxtest-${PLATFORM}_1.0.38_armv8-2a.tar.gz;name=camxtest \ |
There was a problem hiding this comment.
Why are you changing it here? It should still be ${PV}.
There was a problem hiding this comment.
Why are you changing it here? It should still be
${PV}.
The version wasn’t in line because the tar and recipe version were different. I’m working on making the version consistent for camxtest from the next release onward, so it is hardcoded.
There was a problem hiding this comment.
Is it explained in the commit message?
There was a problem hiding this comment.
updated commit message
Update the headers tar to align with the sources. Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
- Correct defaultmctf type from INT to BYTE. - Updated runtime feature library checks for EIS and LDC static capability publishing. - Enabled dual VC mode support for BayerFusionStaticSHDR. - Replaced static OpenCL linkage with dynamic loading in BayerFusionStaticSHDR and YUVFusionSHDR. - Updated iwarp feature to dynamically load OpenCL/OpenGL libraries at runtime. - 'nativehaltest' moved from /usr/bin/camx/<soc>/ to /usr/libexec/camx-<soc>/. - The OpenCL source (.cl) files are now converted into .h header files. Therefore, explicit installation of the .cl files is no longer required. Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
- The OpenCL source (.cl) files are now converted into .h header files. Therefore, explicit installation of the .cl files is no longer required. - 'nativehaltest' moved from /usr/bin/camx/<soc>/ to /usr/libexec/camx-<soc>/. Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
- Fixed stride handling issues in the HIDRX library. - Replaced static OpenCL linkage with dynamic library loading in the HIDRX library. - Added static capability publishing support for EIS and LDC features. - Enabled OX03F10 GMSL RAW10 linear mode on IQ615EVK Talos (1920x1536 @ 30fps, 2-lane, 512 Mbps), including sensor pipeline updates, output resolution fixes, embedded/stats data removal, and mirror mode disablement for the MAX96717/MAX96724 GMSL setup. - Updated iwarp feature to dynamically load OpenCL/OpenGL libraries at runtime. Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
- Added basic camera tuning support for IMX577. - Updated IMX577 tuning project to align with the latest schema. - Migrated all IMX688 sensor mode tuning files to the new schema. - Add com.qti.stats.hafoverride.so library for AF support. - The version wasn’t in line because the tar and recipe version were different,so it is hardcoded. Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
'nativehaltest' moved from /usr/bin/camx/<soc>/ to /usr/libexec/camx-<soc>/, since /usr/bin should hold only flat, directly user-invocable executables, not per-SoC subdirectories. The qcom_nhx file context still pointed at the old path, so the binary no longer picked up the qcom_nhx_exec_t label, and domtrans_pattern(qcom_nhx_launcher_t, qcom_nhx_exec_t, qcom_nhx_t) never matched — nativehaltest stayed in the launcher domain and would hit AVC denials on qcom_nhx_t's DMA, FastRPC, and V4L access. Update the file context to track the new path: - /usr/bin/camx/.*/nativehaltest -> /usr/libexec/camx-[^/]*/nativehaltest No policy rules are changed. Signed-off-by: Rohit Biradar <rohibira@qti.qualcomm.com> Signed-off-by: Ganesh Khose <gkhose@qti.qualcomm.com>
abffebc to
737d1eb
Compare
camxcommon-headers: Update to the 1.0.13 revision.
camxlib-kodiak: Update to the 1.0.27 revision
camxlib-lemans: Update to the 1.0.30 revision
camxlib-talos: Update to the 1.0.30 revision