fix(generate_flat_build): bundle all CDT variants in flash dirs. - #74
Open
Akhil-Sriramulu (sriram-akhil) wants to merge 1 commit into
Open
fix(generate_flat_build): bundle all CDT variants in flash dirs.#74Akhil-Sriramulu (sriram-akhil) wants to merge 1 commit into
Akhil-Sriramulu (sriram-akhil) wants to merge 1 commit into
Conversation
Previously, flash outputs were generated per board variant, differing only by the CDT binary. This required separate flash directories and duplicated common boot artifacts. Update flash generation to include all CDT variants in every flash directory and remove board-specific CDT references from rawprogram XMLs. CDT archives are now downloaded, unpacked, and staged for all supported boards, while boot binaries remain target-specific. Each flash directory now contains: - vision-kit CDT → cdt.bin (default flash target) - core-kit CDT → cdt_core_kit.bin - industrial-kit → cdt_industrial_kit.bin This reduces duplication and enables a single reusable flash directory across board variants. Signed-off-by: Sriramulu Akhil <sakhil@qti.qualcomm.com>
Akhil-Sriramulu (sriram-akhil)
requested review from
Anuj Mittal (anujm1),
gyenugul and
shivshah3400
as code owners
September 3, 2026 07:18
Anuj Mittal (anujm1)
requested changes
Sep 3, 2026
Anuj Mittal (anujm1)
left a comment
Anuj Mittal (anujm1)
left a comment
Contributor
There was a problem hiding this comment.
Please remove add_board blocks as well for these variants and remove useless AI generated comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, flash outputs were generated per board variant, differing only by the CDT binary. This required separate flash directories and duplicated common boot artifacts.
Update flash generation to include all CDT variants in every flash directory and remove board-specific CDT references from rawprogram XMLs. CDT archives are now downloaded, unpacked, and staged for all supported boards, while boot binaries remain target-specific.
Each flash directory now contains:
This reduces duplication and enables a single reusable flash directory across board variants.