Fix undefined symbol errors in libxdsprpc.so on Android - #375
Open
Vinayak Katoch (quic-vkatoch) wants to merge 2 commits into
Open
Fix undefined symbol errors in libxdsprpc.so on Android#375Vinayak Katoch (quic-vkatoch) wants to merge 2 commits into
Vinayak Katoch (quic-vkatoch) wants to merge 2 commits into
Conversation
Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>
- Guard get_dsp_arch_from_yaml in fastrpc_config_parser.h with __ANDROID__ so Android sees a NULL-returning inline stub instead of an unresolved symbol (fastrpc_config_parser.c is not compiled on Android) - Move _LIBADD assignments inside the ANDROID_CC block so -llog is actually passed to the linker; drop the now-dead $(USE_LOG) reference from the non-Android else branch Signed-off-by: Vinayak Katoch <vinayak.katoch@oss.qualcomm.com>
Vinayak Katoch (quic-vkatoch)
requested review from
Chenna Kesava Raju (Chennak-quic) and
Ekansh Gupta (ekanshibu)
August 11, 2026 18:57
Ekansh Gupta (ekanshibu)
approved these changes
Aug 12, 2026
Chenna Kesava Raju (Chennak-quic)
approved these changes
Sep 2, 2026
Contributor
|
Pre-merge CI results — patch Validated On
Kernel: Test Matrix
LAVA Jobs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed when running
fastrpc_teston Android:Two undefined symbols identified:
__android_log_print—_LIBADDassignments were in the else block ofif ANDROID_CCin src/Makefile.am, so-llogwas never passed to the linker for libadsprpc, libcdsprpc, and libsdsprpc.get_dsp_arch_from_yaml— fastrpc_config_parser.c is excluded from Android builds but its header declared the function unconditionally. Fixed by guarding with#ifndef __ANDROID__and providing a static inline stub returningNULL.