Spawn Unsigned userPD by default - #388
Open
Mahima Bhattaram (m-bhattar) wants to merge 1 commit into
Open
Conversation
|
|
||
| // Only apply arch version check for CDSP domain; other domains (e.g. ADSP) | ||
| // do not support unsigned modules, so keep their existing behavior. | ||
| if (dom == CDSP_DOMAIN_ID) { |
Contributor
There was a problem hiding this comment.
Missing CDSP1_DOMAIN_ID
Should we consider GDSP0/1 here as well, or is it not applicable?
| // Only apply arch version check for CDSP domain; other domains (e.g. ADSP) | ||
| // do not support unsigned modules, so keep their existing behavior. | ||
| if (dom == CDSP_DOMAIN_ID) { | ||
| VERIFY(AEE_SUCCESS == (nErr = fastrpc_get_arch_version(domain, &arch_version))); |
Contributor
There was a problem hiding this comment.
Any failure here will fall to bail and fail domain_init entirely. Drop the VERIFY, and return AEE_SUCCESS from fastrpc_get_arch_version when the capability is unsupported, keeping *arch_version = 0 as fallback.
| // do not support unsigned modules, so keep their existing behavior. | ||
| if (dom == CDSP_DOMAIN_ID) { | ||
| VERIFY(AEE_SUCCESS == (nErr = fastrpc_get_arch_version(domain, &arch_version))); | ||
| if (arch_version < 0x81) { |
Contributor
There was a problem hiding this comment.
Shouldn't we define a named constant with a comment explaining this arch version?
Contributor
|
|
Spawns unsigned userpd by default for those with unsigned pd support. This is currently only for CDSP, GPDSP0, and GPDSP1. Signed-off-by: Mahima Bhattaram <mbhattar@qti.qualcomm.com>
Mahima Bhattaram (m-bhattar)
force-pushed
the
unsigned_default
branch
from
August 28, 2026 10:27
faec8ea to
ebb4ce9
Compare
Mahima Bhattaram (m-bhattar)
requested a review
from Vinayak Katoch (quic-vkatoch)
August 29, 2026 07:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spawn unsigned userpd by default for those with unsigned pd support. This is currently only for CDSP, GPDSP0, and GPDSP1.