fix(docs): resolve Taylor expansion flakiness in Fermi-Hubbard FQE tutorial (#870) - #1451
fix(docs): resolve Taylor expansion flakiness in Fermi-Hubbard FQE tutorial (#870)#1451akushnarov wants to merge 2 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Code Review
This pull request updates the Fermi-Hubbard tutorial notebook by setting a random seed to ensure reproducibility when initializing the wavefunction randomly, and reducing the time evolution parameter e_time from 0.9 to 0.1. There are no review comments, so no additional feedback is provided.
f1fd3cd to
a56c874
Compare
a56c874 to
44a9a3d
Compare
|
@akushnarov thank you for this work! As a matter of software engineering best practices, it's better to create separate PRs for separate concerns. Mixing CI refactoring into a documentation bugfix makes git history tracking and rollbacks harder. (C.f. Small CLs.) With that in mind, could you please split out the CI work and the Dependabot configuration change into their own separate PRs (one for each of the latter)? |
Summary
Fixes sporadic numerical divergence and flakiness during time evolution in the Fermi-Hubbard tutorial notebook (
docs/fqe/tutorials/fermi_hubbard.ipynb).Fixes #870
Problem & Root Cause
In
docs/fqe/tutorials/fermi_hubbard.ipynb, the time evolution demo calls:init_wfn.set_wfn(strategy="random")without an explicit random seed, creating arbitrary initial spectral weights.e_time = 0.9resulted in a large Taylor expansion parameter (Solution & Approach
np.random.seed(0)) before generating the random initial state for deterministic reproducibility.e_time = 0.1(fidelity == 1.0) against matrix exponentiation.Validation
check/nbformatpassed cleanly.