Allow quantum if with multiple effects#174
Open
dstrain115 wants to merge 2 commits intoquantumlib:mainfrom
Open
Allow quantum if with multiple effects#174dstrain115 wants to merge 2 commits intoquantumlib:mainfrom
dstrain115 wants to merge 2 commits intoquantumlib:mainfrom
Conversation
Collaborator
dstrain115
commented
Dec 15, 2023
dstrain115
commented
- Note that all effects must apply to the same qubits.
- Note that all effects must apply to the same qubits.
madcpf
reviewed
Dec 15, 2023
| )(piece2) | ||
|
|
||
| # Test that results are as expected | ||
| results = board.peek([piece, piece2], count=100) |
Collaborator
There was a problem hiding this comment.
Is this test finished?
Also could you add another test with multiple qubits, e.g. Split?
madcpf
reviewed
Dec 15, 2023
| """Applies a QuantumEffect conditionally to the specified qubits. | ||
|
|
||
| If multiple effects are specified, they will all be applied | ||
| (to the same qubits). |
Collaborator
There was a problem hiding this comment.
Should we have a TODO() or a suggestion here for cases where effects are applied to different qubits?
Contributor
|
@dstrain115 This has not had activity for quite some time. For planning purposes, could you say whether you are planning to pursue this further? If so, could you update the branch and respond to the review comments? |
mhucka
added
the
status/awaiting-response
mhucka
removed
the
status/awaiting-response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.