Handle member errors in launch - #214
Open
geoand wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
The reason I want this is because of https://github.com/quarkusio/quarkus-ecosystem-ci/actions/runs/24431855021/job/71377792956 which lead to quarkiverse/quarkus-langchain4j#2341 |
gastaldi
reviewed
Apr 16, 2026
Member
|
I wonder if we should close the #216 issue manually if it's open and the build passes? |
Contributor
Author
|
Yeah, that definitely makes sense. Let me try and update the PR |
With this change, a single member failure does not cause the entire loop to fail. Instead, a new issue is created that contains all the failed members
gastaldi
reviewed
Apr 17, 2026
gastaldi
reviewed
Jun 3, 2026
| with: | ||
| github-token: ${{ secrets.ECOSYSTEM_CI_TOKEN }} | ||
| script: | | ||
| const issueNumber = 216; |
Member
There was a problem hiding this comment.
For maintainability purposes, it would be better if we had that in an env var (since it's also declared in the workflow step below)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, a single member failure
does not cause the entire loop to fail.
Instead, a new issue is created that contains
all the failed members
N.B. We'll need to create the
ci-failurelabel