Register extensions from quarkus-renarde - #235
Conversation
|
cc @FroMage |
|
What this does is make the extension available on extensions.quarkus.io and code.quarkus.io. More details are here: https://hub.quarkiverse.io/checklistfornewprojects/#make-your-extension-available-in-the-tooling |
|
🤔 I wonder what to do with those. They're optional modules of Renarde, but they're not the only optional modules: some of the others are not extensions. These have to be, but from the user's PoV they're not different. So why list those, but not the others? I am unsure what the policy around optional extension modules is and what to do here… |
|
Yeah, we've had a few similar tricky cases. I guess one question is 'would anyone ever want to do |
|
Yes, they would, equally whether it's a module or extension. The only ones that we don't want people to explicitly add are modules/extensions that are meant to be used as dependencies by front-facing modules/extensions. |
|
Ok, sounds like it should go into the registry? |
|
We can only add extensions in the registry, right? If yes, then I think we have a problem, because I don't think it makes sense to list an (toplevel) extension's optional extensions, but not its non-extension optional modules. From the PoV of users these should be equal: they provide optional functionality and nobody cares whether it's an extension or not. If we add only optional extensions, then users might think that that's all there is, but it's not, and they will need to look at the docs to find out what's missing from completion. |
|
Oof, yes, I don't think we really considered non-extension modules for extensions. We have a few of those in main quarkus, like JUnit, and they frustrate me because the process for managing those dependencies is different than for everything else. I've been tempted to make it an extension just for consistency but that's kind of the tail wagging the dog. |
|
Renarde has these modules:
I don't think users should treat any of those differently based on them being extensions or simple modules. BTW, I think |
This PR registers newly discovered extensions from quarkus-renarde.
New extensions
quarkus-renarde-backoffice(io.quarkiverse.renarde) (cc @quarkiverse/quarkiverse-renarde)quarkus-renarde-jpa(io.quarkiverse.renarde) (cc @quarkiverse/quarkiverse-renarde)quarkus-renarde-transporter(io.quarkiverse.renarde) (cc @quarkiverse/quarkiverse-renarde)Created automatically by auto-register-extensions