fix: Comment out unused JBoss Logging message interface methods - #210
Open
rhusar wants to merge 1 commit into
Open
fix: Comment out unused JBoss Logging message interface methods#210rhusar wants to merge 1 commit into
rhusar wants to merge 1 commit into
Conversation
Comment out unused @Message-annotated methods and constructs across 4 files to reserve their message IDs while removing dead code from compilation (smaller jar, yay!). Clean up imports that became unused as a result. Signed-off-by: Radoslav Husar <rhusar@ibm.com>
Contributor
Author
|
You know what they say, the fastest code is the one that never runs! Anyway, on a tangent why I am digging here, while evaluating state of this and reusability, is there or was there ever any plan of having the proxy implementations be ported as well? The problem is that the mod_cluster handler in Undertow depends a lot of these proxy constructs that didn't get carried over to here. So I was wondering if there is any desire to have them live here. |
Member
|
First, I would have deleted the code completely rather than commenting it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment out unused @Message-annotated methods and constructs across 4 files to reserve their message IDs while removing dead code from compilation (smaller jar, yay!). Clean up imports that became unused as a result.