Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure all container image names in a one place #46504

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Chu3laMan
Copy link

Centralize Container Image Configuration

Description

This PR addresses issue #45746, which aims to make container image configuration more maintainable by centralizing all image references in one place. Currently, image references are scattered across pom.xml files and Java source files, making it difficult to change image sources (e.g., switching from Docker Hub to Quay.io).

Implementation

  • Added a ContainerImagesConfig interface using @ConfigMapping to provide type-safe access to container image names
  • Explicitly specified all registries for consistency (docker.io vs quay.io)
  • Centralized all container image configurations in application.properties
  • Updated relevant code to use the configuration interface instead of hardcoded image names

Note: Not yet completed

@gsmet gsmet force-pushed the bugfix/configure-all-container-image-names-in-a-one-place branch from dcfd49c to a46ea90 Compare February 26, 2025 17:59
@gsmet gsmet marked this pull request as draft February 26, 2025 18:00
@Chu3laMan Chu3laMan marked this pull request as ready for review February 27, 2025 16:00
@maxandersen
Copy link
Member

I'm not following what this is trying to fix. Why should there be a change from docker to quay ? Or vice versa ?

These are list of some subselection of DEv container images - it's not all of them and most won't be used in most apps so why are we wanting it all in one place ?

@Chu3laMan
Copy link
Author

@maxandersen this fix is about to centralize all docker/quay in one place as aforementioned in the ticket, it reveals that some docker/quay images are scattered in many places, so the idea it is to bring them in one place as @radcortez mentioned too.

@geoand geoand self-requested a review March 3, 2025 10:16
Copy link
Member

@radcortez radcortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not enough, since we still require these properties to be used in their proper place for them to actually have any effect in the configuration.

Also, I'm unsure if having them in a single mapping is the way to go. This would require to be accessible to any of the extensions that use the container images and probably each extension knows better what image should be used.

We could use an expression to determine if the base image is from Docker or Quay, and users could easily override that ot point to one of the other (Docker being the default).

Regardless, we need to ensure that all container images can be overridden in our standard configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants