Remove a repeated check from the ServiceInitiatorsTest in the Hibernate Reactive extension #46537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te Reactive extension
gsmet
approved these changes
Feb 28, 2025
yrodiere
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled upon this when looking at some other test in the module, and it felt like we've missed something here, and the test is incomplete... but I'm not as familiar with the HR extension ... so I'm not sure 😃
(The
QUARKUS_HR_SERVICESmap wasn't used, and currently, it's also the same asHR_SERVICES.)@Sanne, maybe you have an idea, as it looks like you've authored the test initially? 🙈