Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Nisse to get OS specific properties #46614

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Mar 4, 2025

New try for #46513

We've enhanced the Nisse plugin to provide a simple compatibility flag to generate the exact same properties than the defunct os-maven-plugin.

The dependency:go-offline problem does work locally.

Copy link

quarkus-bot bot commented Mar 4, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/documentation area/grpc gRPC area/tracing labels Mar 4, 2025
Copy link

quarkus-bot bot commented Mar 4, 2025

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

This comment has been minimized.

Copy link

github-actions bot commented Mar 4, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@gnodet
Copy link
Contributor Author

gnodet commented Mar 4, 2025

I'll have a closer look at the failing tests, they clearly seem related to a missing os.detected.classifier property.

@gsmet
Copy link
Member

gsmet commented Mar 10, 2025

I pushed to main something that might help a bit and rebased. Let's see how it goes.

@gsmet
Copy link
Member

gsmet commented Mar 10, 2025

Copy link

quarkus-bot bot commented Mar 10, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 17f337d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Mar 10, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 17f337d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/quartz/deployment

io.quarkus.quartz.test.timezone.TriggerPrevFireTimeZoneTest.testScheduledJobs - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.quartz.test.timezone.TriggerPrevFireTimeZoneTest.testScheduledJobs(TriggerPrevFireTimeZoneTest.java:61)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green, we can merge!

@gsmet gsmet merged commit 7843777 into quarkusio:main Mar 11, 2025
61 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants