-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Nisse to get OS specific properties #46614
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
I'll have a closer look at the failing tests, they clearly seem related to a missing |
I pushed to |
Status for workflow
|
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green, we can merge!
New try for #46513
We've enhanced the Nisse plugin to provide a simple compatibility flag to generate the exact same properties than the defunct
os-maven-plugin
.The
dependency:go-offline
problem does work locally.