Raise default pool size to 500 for Quarkus REST Client to improve performance #46626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this PR to adapt the Quarkus Rest Client Pool Size to match the one used by Spring Boot Webflux . We have benchmarked Quarkus and Spring Boot in a setup where both service called a 3rd party service and the connection pool was being a blocker for Quarkus. For our Quarkus version it was 20 and Spring Boot had 500. Adapting Quarkus via config to 500 showed it's real potentional. Anyways I know that Quarkus is using the value both for Quarkus Rest (Reactive, Blocking) and RestEasy Classic. Maybe the value 500 it too high for that usecases but I did not find an straightforward way to distinguish between the 3 variants.