Fix gradle devui NoClassDefFound

[Malandril]

This PR fixes #45112.
It fixes the devui NoClassDefFound errors triggered when using the gradle build tool in dev mode and disables the Add extension button.

When #43840 was merged it allowed to dynamically add new extensions using the dev ui but it doesn't work nicelly with gradle projects:

1. It did'nt correctly identify the path of the project with gradle as the current working dir in gradle retrieved here

   quarkus/extensions/vertx-http/deployment/src/main/java/io/quarkus/devui/deployment/menu/ExtensionsProcessor.java

   Line 201 in 43c95ab

   Path projectRoot = Paths.get(System.getProperty("user.dir")).toAbsolutePath().normalize();

   will be in the build/classes/java/main directory and not the project directory and as such will always detect a gradle project as being a maven project
2. In the gradle dev mode task we only explicitly add parentFirstDependencies and as such the maven resolver dependencies are absent from the classpath

   quarkus/devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java

   Line 498 in 43c95ab

   if (file.exists() && configuredParentFirst.contains(artifact.getKey())

3. One all the above is resolved, the io.quarkus.devtools.project.buildfile.GenericGradleBuildFile extensionManager cannot neither list nor add any new extension as it doesn't work outside of the gradle plugin.

[Malandril]

The only way I found to findthe correct gradle project path independent of build language or sourceSet name is to send it as a system property

[Malandril]

getBuildDir() is deprecated

[Malandril]

Was undefined when switching tabs without running tests

[aloubyansky]

@Malandril thanks a lot for looking into this. Perhaps try

diff --git a/devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java b/devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java
index 44457c4fc2..6558f19e77 100644
--- a/devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java
+++ b/devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java
@@ -465,11 +465,14 @@ private DevModeCommandLine newLauncher(final AnalyticsService analyticsService)
         builder.extensionDevModeConfig(appModel.getExtensionDevModeConfig())
                 .extensionDevModeJvmOptionFilter(extensionJvmOptions);
 
+        builder.jvmArgs(
+                "-Dgradle.project.path=" + getProject().getLayout().getProjectDirectory().getAsFile().getAbsolutePath());
+
         analyticsService.sendAnalytics(
                 DEV_MODE,
                 appModel,
                 Map.of(GRADLE_VERSION, getProject().getGradle().getGradleVersion()),
-                getProject().getBuildDir().getAbsoluteFile());
+                getProject().getLayout().getBuildDirectory().getAsFile().get());
 
         final Set<ArtifactKey> projectDependencies = new HashSet<>();
         for (ResolvedDependency localDep : DependenciesFilter.getReloadableModules(appModel)) {
@@ -562,6 +565,7 @@ private void addQuarkusDevModeDeps(DevModeCommandLineBuilder builder, Applicatio
                         configuration.setCanBeConsumed(false);
                         configuration.extendsFrom(platformConfig);
                         configuration.getDependencies().add(getQuarkusGradleBootstrapResolver());
+                        configuration.getDependencies().add(getQuarkusMavenBootstrapResolver());
                         configuration.getDependencies().add(getQuarkusCoreDeployment(appModel));
                     });
             devModeDependencyConfiguration = getProject().getConfigurations()
@@ -585,7 +589,15 @@ private void addQuarkusDevModeDeps(DevModeCommandLineBuilder builder, Applicatio
     }
 
     private Dependency getQuarkusGradleBootstrapResolver() {
-        final String pomPropsPath = "META-INF/maven/io.quarkus/quarkus-bootstrap-gradle-resolver/pom.properties";
+        return getQuarkusBootstrapResolver("quarkus-bootstrap-gradle-resolver");
+    }
+
+    private Dependency getQuarkusMavenBootstrapResolver() {
+        return getQuarkusBootstrapResolver("quarkus-bootstrap-maven-resolver");
+    }
+
+    private Dependency getQuarkusBootstrapResolver(String artifactId) {
+        final String pomPropsPath = "META-INF/maven/io.quarkus/" + artifactId + "/pom.properties";

to add the Maven resolver classes for the extension catalog resolver.

[Malandril]

Thanks @aloubyansky its a lot simpler

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 45c9998.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer-opentelemetry/deployment

✖ io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni - History

• Stream has no elements - java.lang.IllegalArgumentException

java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_Uni(MicrometerTimedInterceptorTest.java:174)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:521)

[aloubyansky]

@Malandril thanks a lot!

@phillip-kruger the change look good to me. Are you ok with it as well?

[phillip-kruger]

Yes