-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the keycloak devservice when using shared network #46710
Conversation
Thanks @jedla97, I believe we need to get back the test, please look at restoring it soon 🙏 |
@sberyozkin I have lot of things in past month, but I have plan look at it this weekend. |
@jedla97 thank you |
Thanks @jedla97, please don't do it on the weekend, if you can find time to do it in the next few weeks it would be great |
fcec035
to
c6ee979
Compare
@jedla97 You probably need to recreate this PR, it is better to rebase, see https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#before-you-contribute |
@sberyozkin branch updated, the issue should be fixed, it's confirmed to work. Also we should probably add label to backport it to 3.19. |
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jedla97
Folks, I'm a bit worried about backporting this as it's a bit hard to follow what this fixes exactly and how. I read the comments in the issue and I'm not sure I fully grasp why we removed the port and why we removed the newly added parameter. Given this parameter was just added, I'm a bit worried about us breaking other things? In any case, some clarification would be welcome. |
Hi @gsmet , I start from previous PR #46141 It removed the To fix it I found two option the one which was implemented in #46141 . With this KC dev service started but was available only on But yesterday the problem #45793 (comment) was found. I don't know the exact setup what they have but the It adding the KC port which in case of shared networks should be always default as the Quarkus app and KC is on same network. The Probably issue was when ussing Maybe @sberyozkin have some insight to add Also note this happen and is fixed only in docker/podman Quarkus native image (maybe even jvm image but I didn't check it) |
Fixes #45793
This is follow up of #46141 as there is seems still be some problems per #45793 (comment)
If you want more info I describe it in #45793 (comment)