Introduce global HTTP proxy settings configuration #50709

ppalaga · 2025-10-24T14:14:21Z

This is how the global HTTP proxy configuration could work. I am open to discuss any aspects of this PR

What is in this PR:

A new quarkus-proxy-config extension
The reactive REST client was made to use the new global settings

TBD:

Other extensions supporting HTTP proxy should be made aware of quarkus-proxy-config
~~Review the new and existing proxy related config docs in quarkus-rest-client-config~~
Revisit https://quarkus.io/guides/rest-client#proxy-support

Closes: Global HTTP proxy settings #50512

ppalaga · 2025-10-24T14:15:10Z

cc @geoand

github-actions · 2025-10-24T14:59:36Z

🎊 PR Preview 50d1785 has been successfully built and deployed to https://quarkus-pr-main-50709-preview.surge.sh/version/main/guides/

Images of blog posts older than 3 months are not available.
Newsletters older than 3 months are not available.

geoand · 2025-10-25T08:31:02Z

Thanks @ppalaga!

CI is not happy currently

ppalaga · 2025-10-28T10:06:57Z

29e6198:

Rebased
Added support for ProxyType in the Reactive REST client when configured via proxy-configuration-name
Checked the docs of the new and old options again

ppalaga · 2025-10-28T11:51:10Z

b27f402: fixed the compilation failures

ppalaga · 2025-10-28T22:43:59Z

Could please some SME assess whether the failed TckRecoveryTests.testCancelWhenParticipantIsUnavailable can somehow be impacted by the current change?

geoand · 2025-10-29T05:59:40Z

cc @xstefank

xstefank · 2025-10-29T07:46:57Z

@ppalaga that test is flaky but it was probably just a timing issue for which we have adjustment config. If it fails again, ping me offline.

ppalaga · 2025-10-29T08:43:09Z

Thanks @xstefank, this PR is ready for review then.

geoand · 2025-10-29T12:04:29Z

Thanks a lot @ppalaga!

I'll try and have a look this week

gsmet

Is there a reason why you went with proxy-config instead of proxy-registry similar to the TLS naming?

They look like very similar things.

Genuinely curious.

ppalaga · 2025-10-29T15:32:10Z

Is there a reason why you went with proxy-config instead of proxy-registry similar to the TLS naming?

Indeed, the design is similar, but unlike with TLS registry, which hosts some key stores and trust stores, there is no real data in this extension. It is only configuration. Anyway, I do not insist on the name.

geoand · 2025-10-31T13:51:22Z

I'm with @gsmet on this, I think proxy-config is going to be confusing

ppalaga · 2025-10-31T14:33:21Z

OK, be it quarkus-proxy-registry.

Anything else, @geoand?

geoand · 2025-10-31T14:34:45Z

I haven't been able to take a look yet unfortunately

ppalaga · 2025-10-31T14:45:13Z

3885a85:

Rebased,
Changed the name to quarkus-proxy-registry

geoand · 2025-10-31T14:54:23Z

🙏🏽

quarkus-bot · 2025-10-31T15:17:21Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 3885a85.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2025-10-31T18:42:34Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 3885a85.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/micrometer-opentelemetry/deployment

❌ io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed - History

Stream has no elements - java.lang.IllegalArgumentException

java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed(MicrometerTimedInterceptorTest.java:150)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:534)

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

❌ io.quarkus.gradle.devmode.IncludedKotlinBuildDevModeTest.main - History

Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:165)

⚙️ MicroProfile TCKs Tests

📦 tcks/microprofile-lra

❌ org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable - History

Expecting the metric Compensated callback was called Expected: a value equal to or greater than <1> but: <0> was less than <1> - java.lang.AssertionError

java.lang.AssertionError: 
Expecting the metric Compensated callback was called
Expected: a value equal to or greater than <1>
     but: <0> was less than <1>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.assertMetricCallbackCalled(TckRecoveryTests.java:210)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable(TckRecoveryTests.java:195)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

geoand

Great stuff, thanks!

ppalaga · 2025-11-03T21:12:44Z

Thanks for the review and merge, @geoand!

Let me file some followup issues.

geoand · 2025-11-04T04:45:41Z

👌

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/rest area/rest-client area/resteasy-classic labels Oct 24, 2025

This comment has been minimized.

Sign in to view

ppalaga force-pushed the i50512 branch from 0ab6b77 to 29e6198 Compare October 28, 2025 10:05

quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation labels Oct 28, 2025

This comment has been minimized.

Sign in to view

ppalaga force-pushed the i50512 branch from 29e6198 to b27f402 Compare October 28, 2025 11:50

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Oct 28, 2025

gsmet reviewed Oct 29, 2025

View reviewed changes

Global HTTP proxy settings, fix quarkusio#50512

3885a85

ppalaga force-pushed the i50512 branch from b27f402 to 3885a85 Compare October 31, 2025 14:44

geoand changed the title ~~Global HTTP proxy settings~~ Introduce global HTTP proxy settings configuration Nov 3, 2025

geoand approved these changes Nov 3, 2025

View reviewed changes

geoand merged commit 12eccb1 into quarkusio:main Nov 3, 2025
61 checks passed

quarkus-bot bot added this to the 3.30 - main milestone Nov 3, 2025

quarkus-bot bot added the kind/enhancement New feature or request label Nov 3, 2025

Ladicek mentioned this pull request Nov 6, 2025

Proxy Registry: refactoring, Redis Client: add support for Proxy Registry #50834

Open

Introduce global HTTP proxy settings configuration #50709

Introduce global HTTP proxy settings configuration #50709

Uh oh!

Conversation

ppalaga commented Oct 24, 2025 • edited by geoand Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ppalaga commented Oct 24, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geoand commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ppalaga commented Oct 28, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

ppalaga commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

ppalaga commented Oct 28, 2025

Uh oh!

geoand commented Oct 29, 2025

Uh oh!

xstefank commented Oct 29, 2025

Uh oh!

ppalaga commented Oct 29, 2025

Uh oh!

geoand commented Oct 29, 2025

Uh oh!

gsmet left a comment

Choose a reason for hiding this comment

Uh oh!

ppalaga commented Oct 29, 2025

Uh oh!

geoand commented Oct 31, 2025

Uh oh!

ppalaga commented Oct 31, 2025

Uh oh!

geoand commented Oct 31, 2025

Uh oh!

ppalaga commented Oct 31, 2025

Uh oh!

geoand commented Oct 31, 2025

Uh oh!

quarkus-bot bot commented Oct 31, 2025

Status for workflow Quarkus Documentation CI

Uh oh!

quarkus-bot bot commented Oct 31, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Status for workflow Quarkus CI

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/micrometer-opentelemetry/deployment

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

⚙️ MicroProfile TCKs Tests

📦 tcks/microprofile-lra

Uh oh!

geoand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ppalaga commented Nov 3, 2025

Uh oh!

geoand commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

ppalaga commented Oct 24, 2025 •

edited by geoand

Loading

github-actions bot commented Oct 24, 2025 •

edited

Loading

geoand commented Oct 25, 2025 •

edited

Loading

ppalaga commented Oct 28, 2025 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Oct 31, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`