Polish JsonUtil#55364
Open
geoand wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
geoand
commented
Jul 9, 2026
| val = (new JsonObject((Map) val)).copy(); | ||
| } else if (val instanceof List) { | ||
| val = (new JsonArray((List) val)).copy(); | ||
| } else if (val instanceof Buffer) { |
Contributor
Author
There was a problem hiding this comment.
This is not needed because instanceof Shareable already makes the check
Member
There was a problem hiding this comment.
Great catch! Yes, we were a bit fast when we migrated that code to Vert.x 5.
Contributor
Author
There was a problem hiding this comment.
I would never have seen if it were not for IntelliJ flagging it :)
cescoffier
approved these changes
Jul 9, 2026
| val = (new JsonObject((Map) val)).copy(); | ||
| } else if (val instanceof List) { | ||
| val = (new JsonArray((List) val)).copy(); | ||
| } else if (val instanceof Buffer) { |
Member
There was a problem hiding this comment.
Great catch! Yes, we were a bit fast when we migrated that code to Vert.x 5.
geoand
added
the
triage/waiting-for-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.