Restore the third callout entry in the Hibernate ORM interceptor example - #56514
Open
rolfedh wants to merge 1 commit into
Open
Restore the third callout entry in the Hibernate ORM interceptor example#56514rolfedh wants to merge 1 commit into
rolfedh wants to merge 1 commit into
Conversation
The <3> marker on the onLoad method lost its entry when quarkusio#47184 folded the EmptyInterceptor entry and the "implement methods" entry into one. Split them again so every marker has an entry directly under the block. Part of quarkusio#56509
Status for workflow
|
|
🎊 PR Preview 382dc35 has been successfully built and deployed to https://quarkus-pr-main-56514-preview.surge.sh/version/main/guides/
|
gsmet
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hibernate ORM guide, Interceptors example: the
<3>marker on theonLoadmethod had no callout entry, so the rendered page shows a circled 3 that points nowhere, and a strict AsciiDoc parser rejects the page.The 2021 original had
<2> Either extend org.hibernate.EmptyInterceptor or implement org.hibernate.Interceptor directly.and<3> Implement methods as necessary.. #47184 replacedEmptyInterceptorwithInterceptorand folded both entries into one<2>, leaving the<3>marker behind. This restores the split:<2>says to implementorg.hibernate.Interceptor, whose methods all have default implementations, and<3>namesonLoadas the example callback.Removing the
<3>marker instead is fine by me if you prefer.Part of #56509