Add the missing callout entry in the Infinispan client Greeting example - #56515
Open
rolfedh wants to merge 1 commit into
Open
Add the missing callout entry in the Infinispan client Greeting example#56515rolfedh wants to merge 1 commit into
rolfedh wants to merge 1 commit into
Conversation
The <2> marker on the Greeting record lost its entry when the guide moved to Protostream 5 (03130c7): the two @protofield entries went away with the fields, but the marker stayed. Add an entry that says what @proto does with the record components. Part of quarkusio#56509
Status for workflow
|
|
🎊 PR Preview 382dc35 has been successfully built and deployed to https://quarkus-pr-main-56515-preview.surge.sh/version/main/guides/
|
gsmet
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Infinispan client guide, "Creating the Greeting POJO": the
<2>marker on theGreetingrecord had no callout entry, so the rendered page shows a circled 2 that points nowhere, and a strict AsciiDoc parser rejects the page.The marker is left over from the Protostream 5 update (03130c7), which replaced a class with two
@ProtoFieldfields (entries<2>and<3>explained the fields) by the@Protorecord and dropped the entries. The new<2>entry says what@Protodoes with the record components, following its Javadoc: "Fields must be public and they will be assigned incremental numbers based on the declaration order. It is possible to override the automated defaults for a field by using the ProtoField annotation."Removing the
<2>marker instead is fine by me if you prefer.Part of #56509