Add a callout list to the Publisher listing in the Quarkus Data tutorial - #56516
Open
rolfedh wants to merge 1 commit into
Open
Add a callout list to the Publisher listing in the Quarkus Data tutorial#56516rolfedh wants to merge 1 commit into
rolfedh wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
|
🎊 PR Preview d9c9a52 has been successfully built and deployed to https://quarkus-pr-main-56516-preview.surge.sh/version/main/guides/
|
rolfedh
force-pushed
the
docs-callouts-quarkus-data-tutorial
branch
from
September 9, 2026 15:57
a16f40f to
0a894d9
Compare
The "Managed session" section has two listings, Publisher and Book, each with <1> and <2> markers, but only one callout list, under Book. A callout list attaches to the block directly above it, so the Publisher markers had no entries. Give each listing its own list, as the tutorial already does for the two classes in "Creating a Discount Service". Part of quarkusio#56509
rolfedh
force-pushed
the
docs-callouts-quarkus-data-tutorial
branch
from
September 9, 2026 16:01
0a894d9 to
0216ad4
Compare
Status for workflow
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quarkus Data Hibernate tutorial, "Managed session": the
PublisherandBooklistings both carry<1>and<2>markers, but the single callout list sits underBookonly. A callout list attaches to the block directly above it, so thePublishermarkers render as circled numbers that point nowhere, and a strict AsciiDoc parser rejects the page.This gives each listing its own list, the way the tutorial already shows the two classes in "Creating a Discount Service": the full entries move under
Publisher, andBookgets two short entries that say the same change applies.If you would rather keep one list, the alternative is to leave the full list under
Publisherand drop the two markers from theBooklisting.Part of #56509