Skip to content

Feature/typst font weight & style #12554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gordonwoodhull
Copy link
Contributor

#10516 points out that we don't support font-weight or font-style in our translation from CSS properties to Typst properties.

We should. Here they are!

Filing as draft because

  1. The tests are in the feature-format matrix, which we don't run automatically.
  2. Not sure whether to put this in 1.8 or 1.7

would have fixed these in #12487 but we don't test ff matrix automatically
@gordonwoodhull gordonwoodhull force-pushed the feature/typst-font-weight-style branch from 9a9c7b9 to 806172a Compare April 15, 2025 22:39
@cderv cderv added this to the v1.8 milestone Apr 16, 2025
@cderv
Copy link
Collaborator

cderv commented Apr 16, 2025

Not sure whether to put this in 1.8 or 1.7

It seems to be working and low impact so I would say ok for 1.7, as I don't like shipping with missing things we know how to do. The other brand local font stuff for HTML is something I would have like to have;

But it may be too late in our release phase schedule...

@cderv cderv requested a review from cscheid April 16, 2025 09:30
@cderv cderv removed this from the v1.8 milestone Apr 16, 2025
@gordonwoodhull gordonwoodhull marked this pull request as ready for review April 16, 2025 11:58
@cscheid
Copy link
Collaborator

cscheid commented Apr 16, 2025

We can consider a 1.7 backport, but I think we've been stable enough with bugs that I'd like to try and make an official release by the end of the week, so to 1.8 it would go.

@cscheid cscheid added this to the v1.8 milestone Apr 16, 2025
@gordonwoodhull gordonwoodhull changed the title Feature/typst font weight style Feature/typst font weight & style Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants